-
Notifications
You must be signed in to change notification settings - Fork 859
DB migration for ug
Variants, based on earlier work by @moz-bozden for kdy
#4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB migration for ug
Variants, based on earlier work by @moz-bozden for kdy
#4891
Conversation
Testing in progress, this is still in draft
|
kdy
wqkdy
kdy
kdy
Size Change: +6 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
kdy
ug
Variants, based on earlier work by @moz-bozden for kdy
I updated the SQL query used here because ...
This returned 0 rows, so I did further investigation.
makes the assumption that the sentence has previously had a corresponding row inserted into
Now ready for review and merge. |
…rt where the equivalent sentence_id does not exist already in sentence_metadata
Refactored based on discussions with @moz-dfeller
Instead, I approached this in two parts:
To test this, I:
Expected value = 13,769 (13,759 new, 10 to update) = 13,769 in database Validation checks passed, sending for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this awesome update! I bet you trained you SQL muscle quite a bit ;) There are just two things:
- I believe the timestamp in your file name has an extraneous
0
at the end, which makes the timestamp inconsistent with the rest of the files - The
created_at
field has a default value ofNOW()
so there is no need to specify it explicitly in this case, but I don't mind either way, so that's just more of a comment :)
Great job 🚀
Thanks @moz-dfeller - yeah this was a good exercise in MySQL - I haven't worked heavily with it for 10 years or so, excellent refresher. I really enjoy SQL so this was a fun challenge. Excellent pickup on the filename - very precise, I like it. This is now renamed, sending back for review / merge. |
Pull Request Form
Type of Pull Request
DB migration to ascribe all existing sentences of
ug
Uyghur toug-Arab
Variant to allow for new sentences to be added ofug-Cyrl
VariantRelated to a listed issue
Acknowledging contributors