-
Notifications
You must be signed in to change notification settings - Fork 858
Add ug-Cyrl and ug-Arab variants to partially resolve #4144 - support Cyrillic orthography in Uyghur #4889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +3 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
moz-dfeller
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @moz-kathyreid :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
language:ug
ئۇيغۇر تىلى, Уйғур тили, Uyghur tili, Uyƣur tili, Uyğur tili
Variant
A language variant request or issues related to language variants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
This PR is 1 of 2 required to facilitate support for Cyrillic orthography in Uyghur. Following merge of this PR, a second PR is required to ascribe all existing sentences for
ug
to theug-Arab
variant.The following checks have been done:
Check there are no sentence validation rules for
ug
that affect the addition of Variants => no rules exist forug
Check only the required files are committed to the PR => yes, only
variants.ts
Check addition of Variants is in alphabetical order in
variants.ts
=> OKCheck that the Variants are correctly applied to the DB => OK
Acknowledging contributors