Modify how UID and GID work in docker-compose.yaml, update DEVELOPMENT.md to match
#4897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-compose.yaml, update DEVELOPMENT.md to matchdocker-compose.yaml, update DEVELOPMENT.md to match
|
Size Change: -7 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
|
Ready for review |
docker-compose.yaml, update DEVELOPMENT.md to matchdocker-compose.yaml, update DEVELOPMENT.md to match
moz-dfeller
requested changes
May 28, 2025
.env-local-docker.example
Outdated
Comment on lines
43
to
45
| #CV_AUTH0_DOMAIN="<domain_here>" | ||
| #CV_AUTH0_CLIENT_ID="<client_id_here>" | ||
| #CV_AUTH0_CLIENT_SECRET="<client_secret_here>" |
There was a problem hiding this comment.
Could you change AUTH0 to FXA here and further below in the docs as well?
Suggested change
| #CV_AUTH0_DOMAIN="<domain_here>" | |
| #CV_AUTH0_CLIENT_ID="<client_id_here>" | |
| #CV_AUTH0_CLIENT_SECRET="<client_secret_here>" | |
| #CV_FXA_DOMAIN="<domain_here>" | |
| #CV_FXA_CLIENT_ID="<client_id_here>" | |
| #CV_FXA_CLIENT_SECRET="<client_secret_here>" |
There was a problem hiding this comment.
Confirming changes made in both .env-local-docker.example and DEVELOPMENT.md CV_AUTH0* => CV_FXA*. Resolved conflict in DEVELOPMENT.md - it was from a previous PR where I added a note about linking Issues and PRs.
Ready for re-review.
moz-dfeller
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
docker-compose.yamlto use defaultGIDandUIDof1000DEVELOPMENT.mdto be clearer, less error-prone, advise on use ofGIDandUIDDescription
This PR reworks
docker-compose.yamlto changeUIDandGID, adds comments to.env-local-docker.exampleto make it easy to follow, and re-writesDEVELOPMENT.mdto remove references to non-Dockerised setups, and adds information on testing.Questions I have in doing this PR
docker-compose.yaml, the following ENV vars for MySQL are specified:Two of these are in
.env-docker-local, two are not. Should they be removed from thedocker-compose.yamlfile and consolidated in.env-local-docker?CV_FXA_*variables be included in the.env-local-docker.examplefile? Or do we want to direct people to Auth0?Testing approach
.env-local-dockeris linted with https://github.com/dotenv-linter/dotenv-linterdocker compose upworks withdocker-compose.yamland.env-local-dockerfilesRelated PR (should be reviewed first)
Acknowledging contributors