Update config-helper to ignore non-existent config.json #4896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
moz-dfeller
requested changes
May 20, 2025
server/src/config-helper.ts
Outdated
Comment on lines
145
to
148
| if (BASE_CONFIG) { | ||
| console.log('Loading config: reading BASE_CONFIG ...') | ||
| return BASE_CONFIG | ||
| } |
There was a problem hiding this comment.
There is no need to check whether BASE_CONFIG exists, because it's always set either with default values or environment variables. So we can we can shorten it here to:
Suggested change
| if (BASE_CONFIG) { | |
| console.log('Loading config: reading BASE_CONFIG ...') | |
| return BASE_CONFIG | |
| } | |
| console.log('Loading config: reading BASE_CONFIG ...') | |
| return BASE_CONFIG |
So regarding The config gets called a lot because it provides a lot information that is required at every step, e.g. the environment alone (i.e. sandbox, stage, prod) is probably needed in a lot of files. We also don't really want to log what gets called because we don't want to pop secrets into logs that are sent around the globe :) |
4 tasks
|
Confirming requested changes have been made re |
moz-dfeller
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
This PR:
configuration-helper.tsand no longer checks for aconfig.jsonfile, which was causing confusion with people setting up their own development environment, as it threw an error if it wasn't found, even though it wasn't required.loadedConfigwhich no longer serves a purpose AFAICTconsole.logI do have some questions about things that I don't understand in this file:
injectedConfigworks, or what purpose it serves?getConfig(), but that would be helpful here.