Skip to content

Migrate Circassian common sentences to <lc>-Cyrl variants #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HarikalarKutusu
Copy link
Contributor

@HarikalarKutusu HarikalarKutusu commented Feb 21, 2025

This is a follow-up for #4791 for Circassian languages (ady and kbd).

If the variant field is empty, they get "moved" to <lc>-Cyrl to distinguish from others in profile.

Until now, except recently added <lc>-Latn-TR-t-<lc>-Cyrl sentences, there are other sentences without variant info, so it is safe.

EDIT: The first commit has already been merged, but here will silently be processed. I hope it is OK.

@HarikalarKutusu HarikalarKutusu requested a review from a team as a code owner February 21, 2025 09:08
@HarikalarKutusu HarikalarKutusu requested review from data-sync-user and removed request for a team February 21, 2025 09:08
@moz-dfeller moz-dfeller merged commit 98eccd9 into common-voice:main Feb 21, 2025
2 checks passed
@moz-dfeller
Copy link
Contributor

ℹ️ There was an issue with the migrations which was fixed here: d4747c6

@HarikalarKutusu
Copy link
Contributor Author

Thank you! Greatly appreciated 💯...

@HarikalarKutusu HarikalarKutusu deleted the fix-circassian-cyrillic-common-sentences-migration branch February 21, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants