[FIX] (URGENT) Add generic *-Cyrl variants for ady and kbd for common sentences #4791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moz-dfeller
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generic Cyrillic variants for sentences common for all locales. Until now we used empty variant info for those, but whenever we added Latin transliterations, people only see them because they have 0 recordings, and Cyrillic ones have at least one recording. To be able to filter them in the profiles, we need to migrate the
sentence_metadatato these new variants - next.The ones in bold are added.
Next will follow migrations in both
adyandkbdlocales.This is urgent because people cannot skip thousands of Latin sentences, so they stopped recording.