-
Notifications
You must be signed in to change notification settings - Fork 859
Add variants for vi
to resolve #4727
#4802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variants for vi
to resolve #4727
#4802
Conversation
vi
to resolve #47vi
to resolve #4727
Size Change: 0 B Total Size: 6.68 MB ℹ️ View Unchanged
|
and this returned:
This is validated via the database. Removing WIP tag, this is ready for review and merge. |
vi
to resolve #4727vi
to resolve #4727
Thank you so much Kathy, for the pull request and the changes to the variant database. Please kindly let me know if there's anything I can do on my end. Very much appreciated! |
Thanks so much @dragonrd3 - this PR is likely to get wrapped into a release in the next few days, then it will be pushed to production. After that, the database cache layer, I would like you to test the following once the variants are available, if you're OK with it:
This will help us rigorously test this PR. Again, thank you for your patience on this once, we understand variants are very important to represent the diversity of language communities. Thân, Kathy |
Hi Kathy, you are my superhero! Thank you so much for submitting the pull request so quickly. I was looking around at old PRs for variants but it would take me much longer and more trial and error. I am so grateful for your help. Thân, dragonrd3 |
Thanks again Kathy! I did reply to your message on Github not knowing that it also came into this mailbox. Absolutely, I will help test the new variants per your guidance, and will report back my findings then.
Thân,Dragon
On Thursday, February 20, 2025 at 12:47:35 PM PST, Kathy Reid ***@***.***> wrote:
Thanks so much @dragonrd3 - this PR is likely to get wrapped into a release in the next few days, then it will be pushed to production. After that, the database cache layer, redis, will need to age out - so it could be up to 24 hours after that before the Tieng Viet variants become available.
I would like you to test the following once the variants are available, if you're OK with it:
- That the variants are displaying as expected in the web interface for adding sentences, if the logged in user has vi as one of the languages in their profile.
- That adding sentences for each variant works successfully
- And that choosing to speak sentences for only a selected variant works correctly for the 3 x Viet variants.
This will help us rigorously test this PR.
Again, thank you for your patience on this once, we understand variants are very important to represent the diversity of language communities.
Thân, Kathy
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
KathyReid left a comment (common-voice/common-voice#4802)
Thanks so much @dragonrd3 - this PR is likely to get wrapped into a release in the next few days, then it will be pushed to production. After that, the database cache layer, redis, will need to age out - so it could be up to 24 hours after that before the Tieng Viet variants become available.
I would like you to test the following once the variants are available, if you're OK with it:
- That the variants are displaying as expected in the web interface for adding sentences, if the logged in user has vi as one of the languages in their profile.
- That adding sentences for each variant works successfully
- And that choosing to speak sentences for only a selected variant works correctly for the 3 x Viet variants.
This will help us rigorously test this PR.
Again, thank you for your patience on this once, we understand variants are very important to represent the diversity of language communities.
Thân, Kathy
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi Kathy,
The new variants for Vietnamese are now available on CommonVoice, hooray!
Per your request, I started to test the new interface.1. Under profile, it correctly shows the three variants, Hà Nội, Huế and Sài Gòn. And it allows me to select one from the three. One question here is what if the person can speak more than one variant? Does he/she need to create different profiles, one for each variant?2. Under Write, the new interface doesn't show the name of the three variants. Instead it shows the subtags, e.g. vi-hanoi, vi-huett and vi-saigon. I think since the interface is for users, the variant names would be a better choice, e.g. Hà Nội, Huế, and Sài Gòn.
I will continue testing and report back my findings. Please let me know if this is the preferred communication channel for you. If not please let me know what you prefer, and I will promptly switch. Thanks,
Thân mến,Dragon
On Thursday, February 20, 2025 at 12:47:35 PM PST, Kathy Reid ***@***.***> wrote:
Thanks so much @dragonrd3 - this PR is likely to get wrapped into a release in the next few days, then it will be pushed to production. After that, the database cache layer, redis, will need to age out - so it could be up to 24 hours after that before the Tieng Viet variants become available.
I would like you to test the following once the variants are available, if you're OK with it:
- That the variants are displaying as expected in the web interface for adding sentences, if the logged in user has vi as one of the languages in their profile.
- That adding sentences for each variant works successfully
- And that choosing to speak sentences for only a selected variant works correctly for the 3 x Viet variants.
This will help us rigorously test this PR.
Again, thank you for your patience on this once, we understand variants are very important to represent the diversity of language communities.
Thân, Kathy
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
KathyReid left a comment (common-voice/common-voice#4802)
Thanks so much @dragonrd3 - this PR is likely to get wrapped into a release in the next few days, then it will be pushed to production. After that, the database cache layer, redis, will need to age out - so it could be up to 24 hours after that before the Tieng Viet variants become available.
I would like you to test the following once the variants are available, if you're OK with it:
- That the variants are displaying as expected in the web interface for adding sentences, if the logged in user has vi as one of the languages in their profile.
- That adding sentences for each variant works successfully
- And that choosing to speak sentences for only a selected variant works correctly for the 3 x Viet variants.
This will help us rigorously test this PR.
Again, thank you for your patience on this once, we understand variants are very important to represent the diversity of language communities.
Thân, Kathy
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Pull Request Form
Type of Pull Request
#4727 add variants for Vietnamese (Tieng Viet)