Skip to content

fix(navbar): add max-width to login-button #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(navbar): add max-width to login-button #4688

merged 1 commit into from
Nov 6, 2024

Conversation

moz-rotimib
Copy link
Contributor

No description provided.

@moz-rotimib moz-rotimib requested a review from a team as a code owner November 6, 2024 14:40
@moz-rotimib moz-rotimib requested review from moz-dfeller and removed request for a team November 6, 2024 14:40
@moz-rotimib moz-rotimib merged commit 56b494d into 609-overhaul-homepage-layout-and-design Nov 6, 2024
2 checks passed
@moz-rotimib moz-rotimib deleted the 664-set-max-with-on-limit-log-in--sign-up-button branch November 6, 2024 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Size Change: +38 B (0%)

Total Size: 6.08 MB

ℹ️ View Unchanged
Filename Size Change
web/dist/1-1.****************.png 9.92 kB 0 B
web/dist/1-2.****************.png 7.71 kB 0 B
web/dist/1-3.****************.png 14.2 kB 0 B
web/dist/1-4.****************.png 24.5 kB 0 B
web/dist/1-5.****************.png 15.8 kB 0 B
web/dist/1-6.****************.png 12.4 kB 0 B
web/dist/1-red-copy.****************.svg 9.1 kB 0 B
web/dist/104.****************.js 8.65 kB 0 B
web/dist/104.****************.css 3.61 kB 0 B
web/dist/187.****************.js 5.61 kB 0 B
web/dist/187.****************.css 3.2 kB 0 B
web/dist/2-1.****************.png 7.14 kB 0 B
web/dist/2-2.****************.png 14.2 kB 0 B
web/dist/2-3.****************.png 10.4 kB 0 B
web/dist/2-4.****************.png 9.92 kB 0 B
web/dist/2-5.****************.png 8.49 kB 0 B
web/dist/262.****************.js 5.5 kB 0 B
web/dist/262.****************.css 3.39 kB 0 B
web/dist/372.****************.css 853 B 0 B
web/dist/372.****************.js 3.14 kB 0 B
web/dist/424.****************.js 16.1 kB 0 B
web/dist/424.****************.css 9.88 kB 0 B
web/dist/440.****************.css 2.86 kB 0 B
web/dist/440.****************.js 6.06 kB 0 B
web/dist/490.****************.css 2.5 kB 0 B
web/dist/490.****************.js 5.97 kB 0 B
web/dist/529.****************.js 908 B 0 B
web/dist/529.****************.css 1.28 kB 0 B
web/dist/569.****************.css 795 B 0 B
web/dist/616.****************.js 1.46 kB 0 B
web/dist/616.****************.css 493 B 0 B
web/dist/655.****************.js 5.38 kB 0 B
web/dist/662.****************.css 3.42 kB 0 B
web/dist/662.****************.js 5.6 kB 0 B
web/dist/782.****************.js 6.65 kB 0 B
web/dist/785.****************.css 5.73 kB 0 B
web/dist/785.****************.js 8.45 kB 0 B
web/dist/791.****************.css 2.84 kB 0 B
web/dist/791.****************.js 6.39 kB 0 B
web/dist/814.****************.css 5.16 kB 0 B
web/dist/814.****************.js 16.5 kB 0 B
web/dist/826.****************.js 8.51 kB 0 B
web/dist/826.****************.css 4.4 kB 0 B
web/dist/863.****************.js 487 B 0 B
web/dist/863.****************.css 493 B 0 B
web/dist/877.****************.css 2.32 kB 0 B
web/dist/877.****************.js 3.43 kB 0 B
web/dist/956.****************.css 1.34 kB 0 B
web/dist/956.****************.js 1.68 kB 0 B
web/dist/964.****************.js 621 B 0 B
web/dist/964.****************.css 391 B 0 B
web/dist/alert.****************.svg 745 B 0 B
web/dist/background-wave-error.****************.svg 402 B 0 B
web/dist/background-wave-success.****************.svg 550 B 0 B
web/dist/background-wave.****************.svg 284 B 0 B
web/dist/challenge-mtn-post.****************.svg 3.3 kB 0 B
web/dist/challenge-mtn-pre.****************.svg 3.36 kB 0 B
web/dist/checkmark.****************.svg 313 B 0 B
web/dist/chevron-left.****************.svg 292 B 0 B
web/dist/chevron-right.****************.svg 294 B 0 B
web/dist/chrome-color.****************.svg 1.96 kB 0 B
web/dist/close-black.****************.svg 820 B 0 B
web/dist/close.****************.svg 820 B 0 B
web/dist/common-voice-mars-neutral.****************.png 126 kB 0 B
web/dist/contact.****************.svg 971 B 0 B
web/dist/contribute.****************.png 600 kB 0 B
web/dist/cv-logo-black.****************.svg 2.33 kB 0 B
web/dist/cv-logo-white.****************.svg 2.85 kB 0 B
web/dist/dashboard.****************.png 955 kB 0 B
web/dist/datasets-intro-background-triangle.****************.svg 446 B 0 B
web/dist/datasets-intro-background.****************.svg 505 B 0 B
web/dist/deepspeech.****************.png 10.7 kB 0 B
web/dist/deepspeech@2x.****************.png 31.6 kB 0 B
web/dist/deepspeech@3x.****************.png 63.2 kB 0 B
web/dist/discourse.****************.png 16.4 kB 0 B
web/dist/discourse.****************.svg 473 B 0 B
web/dist/discourse@2x.****************.png 44.8 kB 0 B
web/dist/discourse@3x.****************.png 74 kB 0 B
web/dist/donate-banner-desktop-coral.****************.svg 600 B 0 B
web/dist/donate-banner-desktop-pink.****************.svg 600 B 0 B
web/dist/donate-bg1.****************.png 57.8 kB 0 B
web/dist/donate-bg2.****************.png 43.4 kB 0 B
web/dist/down-arrow.****************.svg 399 B 0 B
web/dist/dropdown-arrow.****************.svg 165 B 0 B
web/dist/email-bg-light.****************.png 12.7 kB 0 B
web/dist/email-bg-md-light.****************.svg 919 B 0 B
web/dist/email-bg-md.****************.svg 1.11 kB 0 B
web/dist/email-bg-partnerships.****************.png 287 kB 0 B
web/dist/email-bg.****************.png 4.27 kB 0 B
web/dist/exclamation.****************.svg 534 B 0 B
web/dist/fading.****************.svg 322 B 0 B
web/dist/feedback.****************.png 26.4 kB 0 B
web/dist/feedback@2x.****************.png 82.8 kB 0 B
web/dist/feedback@3x.****************.png 269 kB 0 B
web/dist/ff-color.****************.svg 4.21 kB 0 B
web/dist/github.****************.svg 851 B 0 B
web/dist/globe_black.****************.svg 930 B 0 B
web/dist/grid.****************.svg 387 B 0 B
web/dist/guidelines-waves-footer-small.****************.png 11.8 kB 0 B
web/dist/guidelines-waves-footer.****************.png 154 kB 0 B
web/dist/guidelines-waves.****************.png 225 kB 0 B
web/dist/happy-mars@2x.****************.png 23 kB 0 B
web/dist/hex-done.****************.svg 336 B 0 B
web/dist/hex.****************.svg 300 B 0 B
web/dist/home.****************.svg 506 B 0 B
web/dist/ibm.****************.svg 498 B 0 B
web/dist/keyboard.****************.svg 354 B 0 B
web/dist/languages/test.json 20 B 0 B
web/dist/lenovo.****************.svg 912 B 0 B
web/dist/librispeech.****************.png 161 B 0 B
web/dist/light-waves.****************.svg 1.66 kB 0 B
web/dist/listen-bg.****************.svg 1.91 kB 0 B
web/dist/listen.****************.svg 1.73 kB 0 B
web/dist/mail.****************.svg 998 B 0 B
web/dist/main.****************.css 10.5 kB +38 B (+0.36%)
web/dist/main.****************.js 46.7 kB 0 B
web/dist/mars-avatar.****************.svg 1.35 kB 0 B
web/dist/mars-email-success.****************.svg 7.66 kB 0 B
web/dist/mars-request.****************.svg 6.94 kB 0 B
web/dist/mars-sad.****************.svg 6.14 kB 0 B
web/dist/mars.****************.svg 2.63 kB 0 B
web/dist/mesh.****************.svg 492 B 0 B
web/dist/mic.****************.svg 435 B 0 B
web/dist/mozilla-common-voice_foundation-academia.****************.png 10.2 kB 0 B
web/dist/mozilla-common-voice_foundation-community.****************.png 10.9 kB 0 B
web/dist/mozilla-common-voice_foundation-corporates.****************.png 11.9 kB 0 B
web/dist/mozilla-common-voice_foundation-foundations.****************.png 12.3 kB 0 B
web/dist/mozilla-common-voice_foundation-governments.****************.png 7.51 kB 0 B
web/dist/mozilla-common-voice_foundation-mars_small.****************.png 24 kB 0 B
web/dist/mozilla-common-voice_foundation-mars.****************.png 49.3 kB 0 B
web/dist/mozilla-common-voice_foundation-small-business.****************.png 10.6 kB 0 B
web/dist/mozilla-logo.****************.svg 880 B 0 B
web/dist/mozilla.****************.svg 468 B 0 B
web/dist/play.****************.svg 2.1 kB 0 B
web/dist/plus.****************.svg 333 B 0 B
web/dist/question-mark.****************.svg 755 B 0 B
web/dist/red-robot.****************.svg 1.1 MB 0 B
web/dist/releases/cv-corpus-1.json 2.91 kB 0 B
web/dist/releases/cv-corpus-10.0-2022-07-04.json 14.5 kB 0 B
web/dist/releases/cv-corpus-10.0-delta-2022-07-04.json 7.49 kB 0 B
web/dist/releases/cv-corpus-11.0-2022-09-21.json 15 kB 0 B
web/dist/releases/cv-corpus-2.json 4.32 kB 0 B
web/dist/releases/cv-corpus-3.json 4.42 kB 0 B
web/dist/releases/cv-corpus-4-2019-12-10.json 5.48 kB 0 B
web/dist/releases/cv-corpus-5-2020-06-22.json 9.77 kB 0 B
web/dist/releases/cv-corpus-5-singleword.json 2.53 kB 0 B
web/dist/releases/cv-corpus-5.1-2020-06-22.json 9.78 kB 0 B
web/dist/releases/cv-corpus-5.1-singleword.json 2.51 kB 0 B
web/dist/releases/cv-corpus-6.0-2020-12-11.json 10.5 kB 0 B
web/dist/releases/cv-corpus-6.0-singleword.json 3.42 kB 0 B
web/dist/releases/cv-corpus-6.1-2020-12-11.json 10.7 kB 0 B
web/dist/releases/cv-corpus-6.1-singleword.json 3.51 kB 0 B
web/dist/releases/cv-corpus-7.0-2021-07-21.json 13.1 kB 0 B
web/dist/releases/cv-corpus-7.0-singleword.json 3.63 kB 0 B
web/dist/releases/cv-corpus-8.0-2022-01-19.json 13.2 kB 0 B
web/dist/releases/cv-corpus-9.0-2022-04-27.json 14.4 kB 0 B
web/dist/review-waves.****************.png 20.4 kB 0 B
web/dist/robot.****************.png 52.1 kB 0 B
web/dist/runtime.****************.js 2.61 kB 0 B
web/dist/safari-color.****************.svg 8.6 kB 0 B
web/dist/sap.****************.svg 842 B 0 B
web/dist/search.****************.svg 432 B 0 B
web/dist/segment-dots.****************.svg 474 B 0 B
web/dist/sodedif.****************.png 1.96 kB 0 B
web/dist/speak-bg.****************.svg 1.92 kB 0 B
web/dist/speak.****************.svg 1.61 kB 0 B
web/dist/star.****************.svg 562 B 0 B
web/dist/stars-disabled.****************.svg 2.06 kB 0 B
web/dist/stars.****************.svg 2.1 kB 0 B
web/dist/success.****************.svg 1.44 kB 0 B
web/dist/support.****************.svg 1.9 kB 0 B
web/dist/tatoeba.****************.png 21 kB 0 B
web/dist/ted.****************.png 178 B 0 B
web/dist/upload.****************.svg 546 B 0 B
web/dist/vendors.****************.js 379 kB 0 B
web/dist/voxforge.****************.png 10.5 kB 0 B
web/dist/wave-1.****************.svg 446 B 0 B
web/dist/wave-2.****************.svg 809 B 0 B
web/dist/wave-3.****************.svg 468 B 0 B
web/dist/wave-blue.****************.svg 4.39 kB 0 B
web/dist/wave-eq.****************.svg 1.03 kB 0 B
web/dist/wave-fading.****************.svg 346 B 0 B
web/dist/wave-grey.****************.svg 1.83 kB 0 B
web/dist/wave-top.****************.png 5.3 kB 0 B
web/dist/wave.****************.png 196 kB 0 B
web/dist/wave.****************.svg 1.04 kB 0 B
web/dist/waves-md.****************.svg 1.65 kB 0 B
web/dist/waves-small.****************.png 35.1 kB 0 B
web/dist/waves.****************.svg 1.78 kB 0 B
web/dist/waves.****************.png 33.4 kB 0 B
web/dist/waves@2x.****************.png 114 kB 0 B
web/dist/waves@3x.****************.png 228 kB 0 B

compressed-size-action

moz-rotimib added a commit that referenced this pull request Nov 7, 2024
@moz-rotimib
Add sticky navbar (#4675)
5fccd57 
* 613 implement sticky navigation menu  update nav links (#4649)

* test

* feat(home page): redesign nav bar

* remove pontoon key

* contribute menu fixes

* feat(home page): make nav bar sticky
- fix tests

* fix pontoon keys

* fix failing tests

* fix: add box-shadow to navbar
- remove donate button
- update font sizes for links

* fix: add tooltips to menu items
- fix visibility for coming soon items
- remove bottom border from nav

* test: fix contribute menu test

* fix: fix nav items on mobile
- add reusable boolean variable

* fix: hide nav links on contribution pages
- fix navigation modal on mobile

* fix: hide contribution menu items on click outside or clicking on another menu item
- css fixes for menu wrapper

* test: fix failing tests

* fix: CSS fixes for menu wrapper

* fix(navbar): add max-width to login-button (#4688)

* fix(nav bar): add max-width to contribute items

* feat(nav bar): add tooltip to login button

* feat(navbar) add tooltips to navbar items (desktop only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moz-dfeller moz-dfeller Awaiting requested review from moz-dfeller moz-dfeller is a code owner automatically assigned from common-voice/cv-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moz-rotimib