Skip to content

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 19, 2025

Enables support for Go 1.25 (rc1 and later)
Runs all CI tests also on Go 1.25

Fixes #48

Enables support for Go 1.25 (rc1 and later)
Runs all CI tests also on Go 1.25

Fixes cockroachdb#48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stefanb
Copy link
Contributor Author

stefanb commented Jun 20, 2025

CI workflows tested in PR on my fork:

Copy link
Contributor

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermattis petermattis merged commit d6e517c into cockroachdb:main Jun 24, 2025
18 checks passed
@stefanb stefanb deleted the enable-Go-1.25 branch June 24, 2025 15:19
RaduBerinde pushed a commit to cockroachdb/pebble that referenced this pull request Jun 25, 2025
RaduBerinde pushed a commit to cockroachdb/pebble that referenced this pull request Jun 25, 2025
gammazero added a commit to ipfs/kubo that referenced this pull request Jul 2, 2025
… support (#10850)

* Upgrade github.com/cockroachdb/swiss for Go 1.25 support

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6

* Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support

---------

Co-authored-by: gammazero <11790789+gammazero@users.noreply.github.com>
lidel pushed a commit to ipfs/kubo that referenced this pull request Jul 8, 2025
… support (#10850)

* Upgrade github.com/cockroachdb/swiss for Go 1.25 support

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6

* Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support

---------

Co-authored-by: gammazero <11790789+gammazero@users.noreply.github.com>
(cherry picked from commit 6f0c1de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Go 1.25 support
3 participants