-
-
Notifications
You must be signed in to change notification settings - Fork 589
fix(grbl): address a regression in PR #889 related to the grbl-Mega
connection handling
#893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… connection handling
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Type
Bug fix, Enhancement
Description
grbl-Mega
connection handling by adjusting throttle settings inGrblController.js
.configstore
.Changes walkthrough 📝
GrblController.js
Fix connection handling regression for grbl-Mega
src/server/controllers/Grbl/GrblController.js
queryActivity
function.leading
to false.index.js
Update default settings for configstore
src/server/services/configstore/index.js
collection.
.cncrc
Update example configuration with new defaults
examples/.cncrc
settings.