Add event triggers to M0, M1, and M6 commands #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
1 similar comment
8dcb264 to
e063ed6
Compare
75cb584 to
9d31b76
Compare
|
I'm seeing activity on the repo. Is there any interest in this PR? |
|
Hi @carlos-sarmiento |
I've added an event trigger to M0, M1 and M6 commands so that a event defined on the settings would be triggered when these commands are run. If people agree that we should make the change I'll add it to the other controllers to keep behavior consistent
2a75ad7 to
dc93dad
Compare
cheton
approved these changes
Jun 23, 2022
|
Any additional change we need to do to get the PR merged? |
cheton
added a commit
that referenced
this pull request
Aug 19, 2022
|
I need CNCjs 1.9.22 , can someone provide me please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an event trigger to M0, M1 and M6 commands so that a event defined on the settings would be triggered when these commands are run.
If people agree that we should make the change I'll add it to the other controllers to keep behavior consistent