Skip to content

Conversation

goruha
Copy link
Member

@goruha goruha commented Aug 13, 2025

what

  • Move github.event.release.prerelease case to shared workflows

why

  • Having a single point responsible for the conditions

references

Summary by CodeRabbit

  • Chores
    • Updated the CI release workflow to execute the release job for prereleases as well, so prerelease releases follow the standard release process and related artifacts may be published accordingly.
    • Other workflow jobs are unchanged; Homebrew publishing still runs only for non-prereleases, and Docker behavior is unaffected.
    • No user-facing feature changes.

@goruha goruha requested a review from a team as a code owner August 13, 2025 14:01
@github-actions github-actions bot added the size/xs Extra small size PR label Aug 13, 2025
Copy link

mergify bot commented Aug 13, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Aug 13, 2025
Copy link
Contributor

coderabbitai bot commented Aug 13, 2025

📝 Walkthrough

Walkthrough

Removed the prerelease condition from the release job in .github/workflows/build.yml so the release job runs on prerelease releases as well. Other jobs and guards remain unchanged.

Changes

Cohort / File(s) Summary
CI Workflow
.github/workflows/build.yml
Deleted prerelease guard if: ${{ github.event.release.prerelease == false }} from the release job; other jobs/guards unchanged.

Sequence Diagram(s)

sequenceDiagram
  participant GH as GitHub Release Event
  participant WF as Workflow: build.yml
  participant REL as Job: release
  participant HB as Job: homebrew
  participant DKR as Job: docker

  GH->>WF: release event (including prerelease)
  WF->>REL: Run (no prerelease guard)
  WF->>HB: Conditional run (still guarded by prerelease check)
  WF->>DKR: Run as configured (unchanged)
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Prevent release branch manager from advancing tag on prerelease [DEV-3436] Removing the prerelease guard causes the release job to run for prereleases.

Possibly related PRs

Suggested labels

no-release

Suggested reviewers

  • osterman
  • aknysh

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9179bd8 and fa379d4.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/build.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
  • GitHub Check: Lint (golangci)
  • GitHub Check: Build (windows-latest, windows)
  • GitHub Check: Analyze (go)
  • GitHub Check: Lint (golangci)
  • GitHub Check: Summary
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prereleased-conditions-to-shared-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aknysh aknysh added the no-release Do not create a new release (wait for additional code changes) label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.20%. Comparing base (9179bd8) to head (fa379d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   55.16%   55.20%   +0.03%     
==========================================
  Files         271      271              
  Lines       28185    28185              
==========================================
+ Hits        15548    15559      +11     
+ Misses      10874    10861      -13     
- Partials     1763     1765       +2     
Flag Coverage Δ
unittests 55.20% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aknysh aknysh merged commit 6d09d40 into main Aug 13, 2025
96 of 100 checks passed
@aknysh aknysh deleted the prereleased-conditions-to-shared-workflows branch August 13, 2025 14:50
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Aug 13, 2025
Copy link

These changes were released in v1.187.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes) size/xs Extra small size PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants