-
-
Notifications
You must be signed in to change notification settings - Fork 131
Move github.event.release.prerelease case to shared workflows #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
📝 WalkthroughWalkthroughRemoved the prerelease condition from the release job in .github/workflows/build.yml so the release job runs on prerelease releases as well. Other jobs and guards remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Release Event
participant WF as Workflow: build.yml
participant REL as Job: release
participant HB as Job: homebrew
participant DKR as Job: docker
GH->>WF: release event (including prerelease)
WF->>REL: Run (no prerelease guard)
WF->>HB: Conditional run (still guarded by prerelease check)
WF->>DKR: Run as configured (unchanged)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
+ Coverage 55.16% 55.20% +0.03%
==========================================
Files 271 271
Lines 28185 28185
==========================================
+ Hits 15548 15559 +11
+ Misses 10874 10861 -13
- Partials 1763 1765 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These changes were released in v1.187.0. |
what
why
references
Summary by CodeRabbit