-
-
Notifications
You must be signed in to change notification settings - Fork 132
DEV-3331: Release From Branch #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 50.66% 50.77% +0.10%
==========================================
Files 237 237
Lines 25777 25777
==========================================
+ Hits 13061 13089 +28
+ Misses 11085 11052 -33
- Partials 1631 1636 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughThe workflow file Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub
participant Workflow
participant ReleaseJob
GitHub->>Workflow: push event OR pull_request with release/feature label
Workflow->>ReleaseJob: Trigger with prerelease: true, publish: true, format: binary
ReleaseJob-->>Workflow: Execute release logic (fetch tags only)
Assessment against linked issues
Suggested labels
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.github/workflows/test.yml (3)
531-531
: Remove trailing whitespace
This line has trailing spaces, which will cause a YAML lint error.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
539-539
: Limit secret scope
Usingsecrets: inherit
exposes all repository secrets to the reusable workflow. For better security and auditability, consider passing only the specific secrets required by this job.
540-542
: Remove extra blank lines
There are multiple blank lines here; reduce to a single blank line to satisfy YAML lint rules.🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 541-541: too many blank lines
(3 > 0) (empty-lines)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/test.yml
[error] 531-531: trailing spaces
(trailing-spaces)
[warning] 541-541: too many blank lines
(3 > 0) (empty-lines)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Build (macos-latest, macos)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Analyze (go)
- GitHub Check: Lint (golangci)
- GitHub Check: Summary
🔇 Additional comments (2)
.github/workflows/test.yml (2)
534-534
: Confirm reusable workflow branch
Theuses: cloudposse/.github/.github/workflows/shared-go-auto-release.yml@autorelease-fetch-tags-only
reference was updated. Verify that theautorelease-fetch-tags-only
branch or tag exists and is up-to-date in thecloudposse/.github
repo to avoid broken workflow runs.
537-537
: Enable prerelease flag
Addingprerelease: true
is a useful enhancement. Please confirm the upstream reusable workflow supports this input and that any consumers of the release artifacts handle prerelease versions as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/test.yml (1)
530-533
: Ensure workflow triggers on label addition events
Theif
condition checks PR labels, buton: pull_request
is limited toopened
,synchronize
, andreopened
. Label additions won’t retrigger the job.Consider adding
types: [labeled]
underon: pull_request
or switching topull_request_target
withtypes: [labeled]
.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
🧹 Nitpick comments (2)
.github/workflows/test.yml (2)
531-531
: Remove trailing whitespace
Line 531 has trailing spaces.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
540-543
: Remove extra blank lines and trailing spaces
There are multiple blank lines (and trailing spaces) before the end of the job definition.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 540-540: trailing spaces
(trailing-spaces)
[warning] 543-543: too many blank lines
(3 > 0) (empty-lines)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/test.yml
[error] 531-531: trailing spaces
(trailing-spaces)
[error] 540-540: trailing spaces
(trailing-spaces)
[warning] 543-543: too many blank lines
(3 > 0) (empty-lines)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Lint (golangci)
- GitHub Check: Analyze (go)
- GitHub Check: Summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (2)
.github/workflows/test.yml (2)
535-536
: 🛠️ Refactor suggestionMake
publish
andprerelease
flags conditionalHardcoding both flags triggers prereleases on all pushes (e.g., main or release branches). Restrict publishing to pushes and prereleasing to PRs:
-with: - publish: true - prerelease: true +with: + publish: ${{ github.event_name == 'push' }} + prerelease: ${{ github.event_name == 'pull_request' }}
530-532
: 🛠️ Refactor suggestionEnsure release job triggers on label additions
The workflow only listens to
pull_request
events for opened/synchronize/reopened. Addingrelease/feature
later won’t retrigger the job. Includelabeled
inon.pull_request.types
:on: pull_request: - types: [opened, synchronize, reopened] + types: [opened, synchronize, reopened, labeled]🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
🧹 Nitpick comments (4)
.github/workflows/test.yml (4)
531-531
: Remove trailing spacesLint flagged trailing whitespace here. Please trim the line.
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
538-538
: Scopeenvironment
input by trigger
environment: 'feature-releases'
applies to every run. If full releases should use a different environment (e.g.,production
), consider:environment: ${{ github.event_name == 'pull_request' && 'feature-releases' || 'production' }}
533-533
: Pin the external workflow referenceUsing
@main
can introduce breaking changes when that repo updates. Pin to a specific tag or SHA for reproducible releases.
542-542
: Eliminate extra blank linesThere are several consecutive blank lines here. Collapse to a single blank line for clarity.
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 542-542: too many blank lines
(3 > 0) (empty-lines)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/settings.yml
(1 hunks).github/workflows/test.yml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/settings.yml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/test.yml
[error] 531-531: trailing spaces
(trailing-spaces)
[warning] 542-542: too many blank lines
(3 > 0) (empty-lines)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/settings.yml (2)
14-14
: Remove trailing whitespace
Trailing spaces on blank lines can cause YAML lint failures. Please delete the extra spaces on line 14.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 14-14: trailing spaces
(trailing-spaces)
25-25
: Remove extra blank line
There’s an extra blank line after the labels section which triggers a YAML lint warning. You can collapse to a single blank line between sections.🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 25-25: too many blank lines
(1 > 0) (empty-lines)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/settings.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/settings.yml
[error] 14-14: trailing spaces
(trailing-spaces)
[warning] 25-25: too many blank lines
(1 > 0) (empty-lines)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Analyze (go)
- GitHub Check: Lint (golangci)
- GitHub Check: Summary
🔇 Additional comments (2)
.github/settings.yml (2)
15-20
: Confirm wildcard branch policy
You've introduced ademo
environment with a"**/*"
branch policy. Verify that allowing deployments from all branches is intentional and doesn’t expose unintended branches.
21-24
: Addrelease/feature
label
The newrelease/feature
label is correctly defined to trigger prereleases from feature branches and aligns with the workflow changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (2)
.github/workflows/test.yml (2)
3-4
: Trigger on label addition
Labeling a PR won’t rerun this workflow sincepull_request.types
excludeslabeled
.
Add thelabeled
type:on: pull_request: - types: [opened, synchronize, reopened] + types: [opened, synchronize, reopened, labeled]
535-536
: Make publish/prerelease conditional
Hardcoding both totrue
will publish prereleases on push events.
Use expressions instead:- publish: true - prerelease: true + publish: ${{ github.event_name == 'push' }} + prerelease: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'release/feature') }}
🧹 Nitpick comments (2)
.github/workflows/test.yml (2)
531-531
: Trim trailing whitespace
YAML lint flags a trailing space here.-if: |␣ +if: |🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 531-531: trailing spaces
(trailing-spaces)
538-538
: Conditional environment
All releases (even prod pushes) targetfeature-releases
. Consider settingenvironment
based on event or label to keep prod and feature channels separate.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/test.yml
[error] 531-531: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Build (macos-latest, macos)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Lint (golangci)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: Summary
what
release/feature
labelwhy
references
Summary by CodeRabbit