[main] Discover canary steps status #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c77713f to
fbb669a
Compare
ffdfa4c to
2e14154
Compare
Signed-off-by: João Pereira <joao.pereira@broadcom.com>
Signed-off-by: João Pereira <joao.pereira@broadcom.com>
2e14154 to
4a99027
Compare
Samze
approved these changes
Mar 20, 2025
Samze
added a commit
that referenced
this pull request
Mar 20, 2025
* Fix error message for push command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Display current step in the canary deployment Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Fix canary steps tests * Fix continue test instance-step command * Fix integration test for canary --------- Signed-off-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com> Co-authored-by: Sam Gunaratne <sgunaratne@vmware.com>
Samze
added a commit
that referenced
this pull request
Mar 20, 2025
* Fix error message for push command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Display current step in the canary deployment Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Fix canary steps tests * Fix continue test instance-step command * Fix integration test for canary --------- Signed-off-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com> Co-authored-by: Sam Gunaratne <sgunaratne@vmware.com>
a-b
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Fix error message for push command * Display current step in the canary deployment * Fix canary steps tests * Fix continue test instance-step command * Fix integration test for canary --------- Signed-off-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: João Pereira <joao.pereira@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR tests will not pass until we have a version of CAPI that supports the canary weights
This PR enables the command
cf appto display the current and total number of steps in the canary deployment