Support bare repo creation #9905

williammartin · 2024-11-11T15:23:19Z

Description

Acceptance Criteria

Given My cwd is a bare git repository
When I run gh repo create, and I choose the option to push it to GitHub
Then It succeeds in creating and pushing the repo, mirroring all refs

➜  cli-triaging git:(main) ✗ cd non-bare

➜  non-bare git:(feature) git branch | cat
* feature
  main

➜  non-bare git:(feature) cd ..

➜  cli-triaging git:(main) ✗ git clone --bare non-bare bare
Cloning into bare repository 'bare'...
done.

➜  cli-triaging git:(main) ✗ cd bare

➜  bare git:(feature) ~/workspace/cli/bin/gh repo create
? What would you like to do? Push an existing local repository to GitHub
? Path to local repository .
? Repository name bare
? Repository owner williammartin-test-org
? Description
? Visibility Private
✓ Created repository williammartin-test-org/bare on GitHub
  https://github.com/williammartin-test-org/bare
? Add a remote? Yes
? What should the new remote be called? bare
✓ Added remote https://github.com/williammartin-test-org/bare.git
? Would you like to mirror all refs to "bare"? Yes
Enumerating objects: 3, done.
Counting objects: 100% (3/3), done.
Delta compression using up to 10 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 242 bytes | 242.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (1/1), done.
To https://github.com/williammartin-test-org/bare.git
 * [new branch]      feature -> feature
 * [new branch]      main -> main
✓ Mirrored all refs to https://github.com/williammartin-test-org/bare.git

➜  bare git:(feature) gh api /repos/williammartin-test-org/bare/branches | cat
[{"name":"feature","commit":{"sha":"fca77ed5e5be49ff42779f98061bcd0453f9649e","url":"https://api.github.com/repos/williammartin-test-org/bare/commits/fca77ed5e5be49ff42779f98061bcd0453f9649e"},"protected":false},{"name":"main","commit":{"sha":"fcf697da1ed589b88124193e59ca6ba3243a243c","url":"https://api.github.com/repos/williammartin-test-org/bare/commits/fcf697da1ed589b88124193e59ca6ba3243a243c"},"protected":false}]%

Given My cwd is a bare git repository
When I run gh repo create --source . --push --private
Then It succeeds in creating and pushing the repo, mirroring all refs

➜  cli-triaging git:(main) ✗ cd non-bare

➜  non-bare git:(feature) git branch | cat
* feature
  main

➜  non-bare git:(feature) cd ..

➜  cli-triaging git:(main) ✗ git clone --bare non-bare bare
Cloning into bare repository 'bare'...
done.

➜  bare git:(feature) ~/workspace/cli/bin/gh repo create williammartin-test-org/bare --source . --push --private --remote bare
✓ Created repository williammartin-test-org/bare on GitHub
  https://github.com/williammartin-test-org/bare
✓ Added remote https://github.com/williammartin-test-org/bare.git
Enumerating objects: 3, done.
Counting objects: 100% (3/3), done.
Delta compression using up to 10 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 242 bytes | 242.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (1/1), done.
To https://github.com/williammartin-test-org/bare.git
 * [new branch]      feature -> feature
 * [new branch]      main -> main
✓ Mirrored all refs to https://github.com/williammartin-test-org/bare.git

➜  bare git:(feature) gh api /repos/williammartin-test-org/bare/branches | cat
[{"name":"feature","commit":{"sha":"fca77ed5e5be49ff42779f98061bcd0453f9649e","url":"https://api.github.com/repos/williammartin-test-org/bare/commits/fca77ed5e5be49ff42779f98061bcd0453f9649e"},"protected":false},{"name":"main","commit":{"sha":"fcf697da1ed589b88124193e59ca6ba3243a243c","url":"https://api.github.com/repos/williammartin-test-org/bare/commits/fcf697da1ed589b88124193e59ca6ba3243a243c"},"protected":false}]%

Acceptance Test

I also created an Acceptance Test:

➜ set -o pipefail | GH_ACCEPTANCE_SCRIPT=repo-create-bare.txtar GH_ACCEPTANCE_HOST=github.com GH_ACCEPTANCE_ORG=gh-acceptance-testing go test -tags acceptance -run '^TestRepo' -json github.com/cli/cli/v2/acceptance | tparse --all go test
┌───────────────────────────────────────────────────────────────────────────────────┐
│  STATUS │ ELAPSED │           TEST            │             PACKAGE               │
│─────────┼─────────┼───────────────────────────┼───────────────────────────────────│
│  PASS   │    4.23 │ TestRepo/repo-create-bare │ github.com/cli/cli/v2/acceptance  │
│  PASS   │    0.00 │ TestRepo                  │ github.com/cli/cli/v2/acceptance  │
└───────────────────────────────────────────────────────────────────────────────────┘
┌────────────────────────────────────────────────────────────────────────────────────┐
│  STATUS │ ELAPSED │             PACKAGE              │ COVER │ PASS │ FAIL │ SKIP  │
│─────────┼─────────┼──────────────────────────────────┼───────┼──────┼──────┼───────│
│  PASS   │  4.82s  │ github.com/cli/cli/v2/acceptance │  --   │  2   │  0   │  0    │
└────────────────────────────────────────────────────────────────────────────────────┘

BagToad

LGTM 👍

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.62.0` -> `v2.63.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.63.0`](https://github.com/cli/cli/releases/tag/v2.63.0): GitHub CLI 2.63.0 [Compare Source](cli/cli@v2.62.0...v2.63.0) #### What's Changed - Support bare repo creation by [@williammartin](https://github.com/williammartin) in cli/cli#9905 - Refactor the `getAttestations` functions by [@malancas](https://github.com/malancas) in cli/cli#9892 - Added a section on manual verification of the relases. by [@kommendorkapten](https://github.com/kommendorkapten) in cli/cli#9936 - Adding option to return `baseRefOid` in `pr view` by [@daliusd](https://github.com/daliusd) in cli/cli#9938 - Update verification results printing by [@malancas](https://github.com/malancas) in cli/cli#9937 - Fix some multiline command documentation to use `heredoc` strings by [@BagToad](https://github.com/BagToad) in cli/cli#9948 - Print friendly error when `release create` fails due to missing `workflow` OAuth scope by [@BagToad](https://github.com/BagToad) in cli/cli#9791 **Full Changelog**: cli/cli@v2.62.0...v2.63.0 #### Security - A security vulnerability has been identified in the GitHub CLI that could leak authentication tokens when cloning repositories containing git submodules hosted outside of GitHub.com and ghe.com. For more information, see GHSA-jwcm-9g39-pmcw #### New Contributors - [@daliusd](https://github.com/daliusd) made their first contribution in cli/cli#9938 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

williammartin added 8 commits November 11, 2024 13:57

Support bare repo creation

4a7f2e5

Backfill repo creation failure tests

bc85e11

Use errWithExitCode interface in repo create isLocalRepo

f515e9c

Doc isLocalRepo and git.Client IsLocalRepo differences

2efb993

Add acceptance test for bare repo create

6a97dbf

Push --mirror on bare repo create

e366595

Doc push behaviour for bare repo create

8e63268

Modify push prompt on repo create when bare

7bcb063

williammartin requested a review from a team as a code owner November 11, 2024 15:23

williammartin requested a review from BagToad November 11, 2024 15:23

williammartin linked an issue Nov 11, 2024 that may be closed by this pull request

gh repo create to work on bare repos #9904

Closed

cliAutomation assigned williammartin Nov 11, 2024

williammartin mentioned this pull request Nov 11, 2024

gh repo create to work on bare repos #9904

Closed

Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos

04e2a5d

BagToad approved these changes Nov 15, 2024

View reviewed changes

BagToad enabled auto-merge November 15, 2024 19:01

BagToad merged commit 9decf1b into trunk Nov 15, 2024

BagToad deleted the 9904-gh-repo-create-to-work-on-bare-repos branch November 15, 2024 19:08

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support bare repo creation #9905

Support bare repo creation #9905

Uh oh!

williammartin commented Nov 11, 2024

Uh oh!

BagToad left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

Support bare repo creation #9905

Support bare repo creation #9905

Uh oh!

Conversation

williammartin commented Nov 11, 2024

Description

Acceptance Criteria

Acceptance Test

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!