fix(helm): document importance of correct clusterDomain for kamaji-etcd subchart #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
prometherion
approved these changes
May 26, 2025
|
Please, can you amend changes of This will generate the README.md file referencing the variable you're correctly identified. |
…cd subchart If one's management cluster domain is not "cluster.local", the init jobs will fail. As the value is configurable but is defined in a subchart, it is not immediately discoverable from the part chart. Add a values.yaml config with a note about its importance. Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Done, but I don't think that had the intended result -- I also don't grok |
|
No worries @rpardini, you made it: LGTM and thanks for being a Kamaji contributor! |
mridulgain
added a commit
to platform9/kamaji
that referenced
this pull request
Aug 1, 2025
* feat(deps): bump github.com/testcontainers/testcontainers-go (clastix#802) Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/testcontainers/testcontainers-go/releases) - [Commits](testcontainers/testcontainers-go@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: github.com/testcontainers/testcontainers-go dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: releasing helm latest version (clastix#805) * chore(github): releasing helm latest version Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(helm): releasing helm latest version Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: releasing helm latest version Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(docs): upgrading supported k8s matrix Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(deps): bump github.com/nats-io/nats.go from 1.41.2 to 1.42.0 (clastix#807) Bumps [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go) from 1.41.2 to 1.42.0. - [Release notes](https://github.com/nats-io/nats.go/releases) - [Commits](nats-io/nats.go@v1.41.2...v1.42.0) --- updated-dependencies: - dependency-name: github.com/nats-io/nats.go dependency-version: 1.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(helm): upgrading kamaji-etcd to v0.10.0 (clastix#808) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(helm): missing docs for kamaji-etcd dependency bump from 0.9.2 to 0.10.0 (clastix#809) * fix(ci): lint and diff for helm jobs Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs(helm): bump kamaji-etcd dependency from 0.9.2 to 0.10.0 Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(ci): semantic pr title (clastix#810) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * refactor!: k8s api server validation for kubelet preferred address type uniqueness (clastix#812) * feat(api): relying on k8s list set for unique items Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(crd)!: relying on k8s list set for unique items Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(webhook): removing unused webhook for kubelet preferred address type Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs(crd): kubelet preferred address type uniqueness Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * Update kamaji-kind.md to install Clastix Helm repo (clastix#818) * feat(deps): bump k8s.io/kubernetes in the k8s group (clastix#815) Bumps the k8s group with 1 update: [k8s.io/kubernetes](https://github.com/kubernetes/kubernetes). Updates `k8s.io/kubernetes` from 1.33.0 to 1.33.1 - [Release notes](https://github.com/kubernetes/kubernetes/releases) - [Commits](kubernetes/kubernetes@v1.33.0...v1.33.1) --- updated-dependencies: - dependency-name: k8s.io/kubernetes dependency-version: 1.33.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump sigs.k8s.io/controller-runtime from 0.20.4 to 0.21.0 (clastix#819) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.20.4 to 0.21.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.20.4...v0.21.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump github.com/go-logr/logr from 1.4.2 to 1.4.3 (clastix#825) Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/go-logr/logr/releases) - [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md) - [Commits](go-logr/logr@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/go-logr/logr dependency-version: 1.4.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump github.com/docker/docker (clastix#824) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.1.1+incompatible to 28.2.0+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.1.1...v28.2.0) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-version: 28.2.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(helm): document importance of correct clusterDomain for kamaji-etcd subchart (clastix#822) Signed-off-by: Ricardo Pardini <ricardo@pardini.net> * feat(k8s): upgrade support to v1.33.1 (clastix#826) * feat(k8s): upgrade support to v1.33.1 Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(deps): upgrade support to k8s v1.33.1 Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(adopters): add CBWS (clastix#830) * feat(deps): bump github.com/docker/docker (clastix#829) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.2.0+incompatible to 28.2.2+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.2.0...v28.2.2) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-version: 28.2.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(docs): terraform guide (clastix#832) * feat(docs): add terraform guide * fix(docs): update metallb annotation * feat(deps): bump github.com/nats-io/nats.go from 1.42.0 to 1.43.0 (clastix#831) Bumps [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go) from 1.42.0 to 1.43.0. - [Release notes](https://github.com/nats-io/nats.go/releases) - [Commits](nats-io/nats.go@v1.42.0...v1.43.0) --- updated-dependencies: - dependency-name: github.com/nats-io/nats.go dependency-version: 1.43.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: requeue deprecated, migrating to requeue after (clastix#837) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(metrics): exposing resource handlers time bucket (clastix#836) * refactor: static names and avoiding clash Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(metrics): exposing resource handlers time bucket Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat: toggable cleanup schema prior migration (clastix#840) * feat(migration): cleanup prior migration When using the annotation `kamaji.clastix.io/cleanup-prior-migration` with a true boolean value, Kamaji will perform a clean-up on the target DataStore to avoid stale resources when back and forth migrations occur. Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: cleanup prior migration Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(docs): add llms.txt file (clastix#841) * feat(docs): add terraform guide * fix(docs): update metallb annotation * feat(docs): add llms.txt file * feat(docs): add user public quote (clastix#842) * feat(deps): bump github.com/go-sql-driver/mysql from 1.9.2 to 1.9.3 (clastix#843) Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.9.2 to 1.9.3. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/v1.9.3/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.9.2...v1.9.3) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-version: 1.9.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump k8s.io/kubernetes in the k8s group (clastix#844) Bumps the k8s group with 1 update: [k8s.io/kubernetes](https://github.com/kubernetes/kubernetes). Updates `k8s.io/kubernetes` from 1.33.1 to 1.33.2 - [Release notes](https://github.com/kubernetes/kubernetes/releases) - [Commits](kubernetes/kubernetes@v1.33.1...v1.33.2) --- updated-dependencies: - dependency-name: k8s.io/kubernetes dependency-version: 1.33.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(migration): enhancements and customisable timeout (clastix#845) * feat(migration): customising timeout via tcp annotation Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: customising migration timeout via tcp annotation Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(migrate): delete job in case of timeout change This will delete the failed job due to an incorrect timeout and performs the creation of a new object rather than updating it, since its immutability in the API specification. Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(helm): ignoring helm files for stable packaging (clastix#848) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(docs): generating api docs for cluster api objects (clastix#851) * chore(makefile): generating api docs for cluster api objects Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: generating api docs for cluster api objects Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(api): display status version in TenantControlPlane columns (clastix#852) Signed-off-by: alecristofanilli <cristofanillia@gmail.com> * feat(deps): bump github.com/docker/docker (clastix#850) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.2.2+incompatible to 28.3.0+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.2.2...v28.3.0) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-version: 28.3.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(docs): enhancing navigation for api reference (clastix#853) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix: wrong jsonpath for installed version (clastix#857) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(controlplane): Prioritize InternalIP in kubelet-preferred-address-types (clastix#859) This patch switches default kubelet-preferred-address-types to "InternalIP,ExternalIP,Hostname" to avoid failures in kube-apiserver connection to kubelet when node hostnames are not resolvable by the external DNS server. This improves out-of-the-box reliability across most environments by choosing node `InternalIP` as the preferred mode to reach Kubelet. Signed-off-by: Parth Yadav <parthyadav3105@gmail.com> * chore(ci): stripping binaries and avoiding cgo (clastix#861) * chore(docs): aligning to latest capi cp provider docs Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(ci): stripping binaries and avoiding cgo Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(gh): upgrading to ubuntu-latest for e2e Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(test): printing debug messages for node join in e2e Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(ci): ignoring file existing error Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(ci): enabling br_netfilter as github action step Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix(docs): optimize kind getting started (clastix#847) * feat(deps): updating kamaji-etcd and kubeadm dependencies (clastix#865) * feat(deps): upgrading kamaji-etcd helm dependency Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(deps): upgrading kubeadm support to v1.33.2 Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(deps): bump github.com/docker/docker (clastix#869) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.3.0+incompatible to 28.3.2+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.3.0...v28.3.2) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-version: 28.3.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(chore): support for customising container repository via ldflags (clastix#873) Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat: pausing reconciliation of controlled objects (clastix#874) * feat: pausing reconciliation of controlled objects Objects such as TenantControlPlane and Secret can be annotated with kamaji.clastix.io/paused to prevent controllers from processing them. This will stop reconciling objects for debugging or other purposes. Annotation value is irrelevant, just the key presence is evaluated. Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: pausing reconciliation of controlled objects Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(logs): typo for deleted resources Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * fix: typo in llms.txt (clastix#879) * feat(deps): bump github.com/spf13/pflag from 1.0.6 to 1.0.7 (clastix#884) Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.6...v1.0.7) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-version: 1.0.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump github.com/testcontainers/testcontainers-go (clastix#878) Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.37.0 to 0.38.0. - [Release notes](https://github.com/testcontainers/testcontainers-go/releases) - [Commits](testcontainers/testcontainers-go@v0.37.0...v0.38.0) --- updated-dependencies: - dependency-name: github.com/testcontainers/testcontainers-go dependency-version: 0.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat!: support for konnectivity deployment mode (clastix#875) * feat(konnectivity): support for deployment mode Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat(helm)!: support for konnectivity deployment mode Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * chore(sample): support for konnectivity deployment mode Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: support for konnectivity deployment mode Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat: rotating certificates via annotation (clastix#877) * fix(kubeconfig): checking certificate authority data for validity Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * feat: rotating certificates via annotation Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * docs: rotating certificates via annotation Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> --------- Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> * update README & api docs * fix type assertion issue --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dario Tranchitella <dario@tranchitella.eu> Signed-off-by: Ricardo Pardini <ricardo@pardini.net> Signed-off-by: alecristofanilli <cristofanillia@gmail.com> Signed-off-by: Parth Yadav <parthyadav3105@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dario Tranchitella <dario@tranchitella.eu> Co-authored-by: Pierre PIRONIN <pironin.pierre@gmail.com> Co-authored-by: Ricardo Pardini <ricardo@pardini.net> Co-authored-by: Wouter van Os <wouter0100@gmail.com> Co-authored-by: Adriano Pezzuto <2222461+bsctl@users.noreply.github.com> Co-authored-by: Alessandro <81253653+alecristofanilli@users.noreply.github.com> Co-authored-by: Parth Yadav <parthyadav3105@gmail.com> Co-authored-by: Yukiel Zhong <56835284+Yukielz@users.noreply.github.com> Co-authored-by: Mario Valderrama <15158349+avorima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one's management cluster domain is not "cluster.local", the init jobs will fail. As the value is configurable but is defined in a subchart, it is not immediately discoverable from the parent chart.
Add a values.yaml config with a note about its importance.