Add missing consume for image_resize class on image elements.
#18349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice |
|
|
|
@Witoso Isn't it too generic assumption? I enforced it to maximize backward compatibility, as |
|
I would need @mmotyczynska to check but this looks as an improper working of the image consumption. Even if GHS styles something, we normalize it to the feature. |
|
I moved |
True. |
arkflpc
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (image): Consume
image_resizeclass andaspect-ratiostyle during the upcast of the images. Closes #18287Additional information
Previously, the
image_resizeclass was incorrectly consumed by the General HTML Support (GHS) plugin. This class is meant to be handled by theImageResizeplugin only, as it is automatically applied by it. This PR ensures that GHS no longer consumes this attribute.