llvm: Upgrade to LLVM 17.0.6 #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5006eb5 to
22687a2
Compare
rgo3
approved these changes
Mar 28, 2024
Fixes for Clang 17 were merged into the Cilium codebase:
b91046955d6b ("datapath: Ignore new debug ELF prefixes")
6e18eb020b68 ("bpf: Fix compatibility with Clang 17 in __lb6_affinity_backend_id")
3740e9db8fef ("bpf: Fix "R2 !read_ok" verifier error with LLVM 17")
c6fe6b8e2546 ("bpf/tests: Fix `conntrack_test.c` in prep for Clang update")
4dd6b0a4f97f ("bpf/tests: Fix undefined behavior in memcmp MAC addresses")
f87b5dc5e0b2 ("bpf/tests: Fix undefined behavior in EXPECTED_DEST_MAC")
and the complexity measurements were performed, so now the LLVM image
can be upgraded.
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
22687a2 to
5f1b853
Compare
|
@gentoo-root should we also update the required LLVM version in https://docs.cilium.io/en/stable/operations/system_requirements/ ? Given that we no longer test with v10.0, I'm rather skeptical how well Cilium would still work with such older version ... |
HadrienPatte
added a commit
that referenced
this pull request
Jul 31, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Note: also add a renovate comment to manage the LLVM version, see #349 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Jul 31, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Note: also add a renovate comment to manage the LLVM version, see #349 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Jul 31, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Note: also add a renovate comment to manage the LLVM version, see #349 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Aug 1, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Note: also add a renovate comment to manage the LLVM version, see #349 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Aug 1, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Note: also add a renovate comment to manage the LLVM version, see #349 Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Aug 6, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Aug 12, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
pchaigno
pushed a commit
that referenced
this pull request
Aug 23, 2025
This essentially reverts 09f4e53 which is no longer necessary as we don't have any cherry-picks anymore since #267. This improves image build time as a full it clone of `llvm/llvm-project` takes about ~15 min while a release archive download and extraction takes about one minute (not a real benchmark, but it's a perf gain). Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for Clang 17 were merged into the Cilium codebase:
b91046955d6b ("datapath: Ignore new debug ELF prefixes")
6e18eb020b68 ("bpf: Fix compatibility with Clang 17 in __lb6_affinity_backend_id")
3740e9db8fef ("bpf: Fix "R2 !read_ok" verifier error with LLVM 17")
c6fe6b8e2546 ("bpf/tests: Fix
conntrack_test.cin prep for Clang update")4dd6b0a4f97f ("bpf/tests: Fix undefined behavior in memcmp MAC addresses")
f87b5dc5e0b2 ("bpf/tests: Fix undefined behavior in EXPECTED_DEST_MAC")
and the complexity measurements were performed, so now the LLVM image can be upgraded.