-
Notifications
You must be signed in to change notification settings - Fork 3.4k
workflows: Skip code changes as separate step #39792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aditighag
merged 1 commit into
cilium:main
from
aditighag:pr/aditighag/update-ha-workflow
Jun 2, 2025
Merged
workflows: Skip code changes as separate step #39792
aditighag
merged 1 commit into
cilium:main
from
aditighag:pr/aditighag/update-ha-workflow
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
reviewed
May 29, 2025
f8061e2
to
7273047
Compare
christarazi
approved these changes
May 29, 2025
joestringer
reviewed
May 29, 2025
7273047
to
70e07a4
Compare
I created a dummy PR to verify that the logic to skip the workflow based on code changes is working as expected, the skipped run - https://github.com/cilium/cilium/actions/runs/15350728102/job/43198001336?pr=39808. |
70e07a4
to
e62340f
Compare
/test |
This allows the workflow to be marked as required. Suggested-by: Joe Stringer <joe@cilium.io> Signed-off-by: Aditi Ghag <aditi@cilium.io>
e62340f
to
08b485e
Compare
/test |
joestringer
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! 🚢
Filed a CI issue for the flake - #39841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.