Skip to content

workflows: Skip code changes as separate step #39792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

aditighag
Copy link
Member

No description provided.

@aditighag aditighag requested a review from a team as a code owner May 29, 2025 17:09
@aditighag aditighag added the release-note/ci This PR makes changes to the CI. label May 29, 2025
@aditighag aditighag requested a review from a team as a code owner May 29, 2025 17:09
@aditighag aditighag force-pushed the pr/aditighag/update-ha-workflow branch from f8061e2 to 7273047 Compare May 29, 2025 17:19
@aditighag aditighag force-pushed the pr/aditighag/update-ha-workflow branch from 7273047 to 70e07a4 Compare May 29, 2025 18:14
@aditighag
Copy link
Member Author

I created a dummy PR to verify that the logic to skip the workflow based on code changes is working as expected, the skipped run - https://github.com/cilium/cilium/actions/runs/15350728102/job/43198001336?pr=39808.

@aditighag aditighag force-pushed the pr/aditighag/update-ha-workflow branch from 70e07a4 to e62340f Compare May 30, 2025 16:03
@aditighag
Copy link
Member Author

/test

This allows the workflow to be marked as required.

Suggested-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/update-ha-workflow branch from e62340f to 08b485e Compare May 30, 2025 16:05
@aditighag
Copy link
Member Author

/test

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! 🚢

@joestringer joestringer enabled auto-merge May 30, 2025 16:16
@joestringer joestringer added this pull request to the merge queue May 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2025
@aditighag aditighag added this pull request to the merge queue Jun 2, 2025
@aditighag
Copy link
Member Author

Filed a CI issue for the flake - #39841

Merged via the queue into cilium:main with commit 9e5fb2e Jun 2, 2025
68 checks passed
@aditighag aditighag deleted the pr/aditighag/update-ha-workflow branch June 2, 2025 17:30
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants