Skip to content

helm: add Envoy image to pre-flight #39670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

helm: add Envoy image to pre-flight #39670

merged 5 commits into from
Jun 17, 2025

Conversation

gsstuart
Copy link
Contributor

Adds the Envoy image to the pre-flight process, so that Envoy will be pre-pulled during a Cilium upgrade.

Fixes: #39374

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 21, 2025
@gsstuart
Copy link
Contributor Author

/test

@gsstuart gsstuart marked this pull request as ready for review May 21, 2025 23:06
@gsstuart gsstuart requested review from a team as code owners May 21, 2025 23:06
@gsstuart gsstuart requested review from marseel and squeed May 21, 2025 23:06
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label May 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2025
squeed
squeed reviewed May 26, 2025
View reviewed changes
@squeed
Copy link
Contributor

squeed commented May 26, 2025

great idea. A few nits, nothing more.

(please re-request review when ready, otherwise it gets lost in the noise)

@squeed squeed added the area/helm Impacts helm charts and user deployment experience label May 26, 2025
marseel
marseel approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, FYI @cilium/sig-servicemesh

@gsstuart gsstuart requested review from squeed and marseel May 28, 2025 17:42
squeed
squeed approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I agree with filing a follow-up PR to clean up some more of the preflight nits. Thanks!

marseel
marseel approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joestringer
Copy link
Member

It looks like this PR fell through the gaps on testing, sorry. I've triggered some of the smoke tests and they've identified a few things that need to be addressed in this PR prior to merge:

Would you mind updating them, then we can run the full testsuite.

gsstuart added 3 commits June 16, 2025 11:47
@gsstuart @aanm
helm: add Envoy image to pre-flight
bf5c9ae 
Signed-off-by: Scott Stuart <sstuart@doximity.com>
@gsstuart @aanm
allow for overriding envoy preflight image
c9ba49b 
Signed-off-by: Scott Stuart <sstuart@doximity.com>
@gsstuart @aanm
remove environment from Envoy preflight container
01a0916 
Signed-off-by: Scott Stuart <sstuart@doximity.com>
@aanm aanm force-pushed the add-envoy-prepull branch from 0a7a9ac to 01a0916 Compare June 16, 2025 09:47
@aanm aanm enabled auto-merge June 16, 2025 09:47
@aanm
Copy link
Member

aanm commented Jun 16, 2025

/test

@gsstuart
re-run make to update values.yaml
2e07e03 
Signed-off-by: Scott Stuart <sstuart@doximity.com>
auto-merge was automatically disabled June 16, 2025 23:27

Head branch was pushed to by a user without write access

@gsstuart
Copy link
Contributor Author

issues should be addressed now

@gsstuart
update-helm-values
117e213 
Signed-off-by: Scott Stuart <sstuart@doximity.com>
@aanm aanm enabled auto-merge June 17, 2025 09:52
@aanm
Copy link
Member

aanm commented Jun 17, 2025

/test

@aanm aanm added this pull request to the merge queue Jun 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2025
Merged via the queue into cilium:main with commit 2c2ca13 Jun 17, 2025
68 checks passed
@sayboras sayboras mentioned this pull request Aug 1, 2025
Closed
3 tasks
sayboras added a commit that referenced this pull request Aug 1, 2025
@sayboras
helm: Create envoy-config ConfigMap for preflight
df8613e 
After the below PR, Cilium Envoy is part of preflight, hence the related
config map is required if preflight flag is set.

Relates: #39670
Fixes: #40805
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Aug 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2025
@sayboras @joestringer
helm: Create envoy-config ConfigMap for preflight
7293703 
After the below PR, Cilium Envoy is part of preflight, hence the related
config map is required if preflight flag is set.

Relates: #39670
Fixes: #40805
Signed-off-by: Tam Mach <tam.mach@cilium.io>
YutaroHayakawa pushed a commit that referenced this pull request Aug 11, 2025
@sayboras @YutaroHayakawa
helm: Create envoy-config ConfigMap for preflight
6b0eb39 
[ upstream commit 7293703 ]

After the below PR, Cilium Envoy is part of preflight, hence the related
config map is required if preflight flag is set.

Relates: #39670
Fixes: #40805
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2025
@sayboras @aanm
helm: Create envoy-config ConfigMap for preflight
f306afd 
[ upstream commit 7293703 ]

After the below PR, Cilium Envoy is part of preflight, hence the related
config map is required if preflight flag is set.

Relates: #39670
Fixes: #40805
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
rabelmervin pushed a commit to rabelmervin/cilium that referenced this pull request Aug 18, 2025
@sayboras @rabelmervin
helm: Create envoy-config ConfigMap for preflight
d4e337c 
After the below PR, Cilium Envoy is part of preflight, hence the related
config map is required if preflight flag is set.

Relates: cilium#39670
Fixes: cilium#40805
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@marseel marseel marseel approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: Include the Envoy image in pre-flight/pre-pull
5 participants
@gsstuart @squeed @joestringer @aanm @marseel