cilium-cli: extend no-interrupted-connections to test Egress Gateway #38193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83134b8 to
905ea00
Compare
|
/test |
905ea00 to
ae37941
Compare
|
/test |
ae37941 to
92d57b7
Compare
|
/test |
giorio94
reviewed
Mar 17, 2025
brlbil
approved these changes
Mar 17, 2025
|
The new test is being skipped in CI. I would prefer to see a run where it passes before approving. https://github.com/cilium/cilium/actions/runs/13890711080/job/38862132656#step:27:258 |
YutaroHayakawa
approved these changes
Mar 17, 2025
asauber
approved these changes
Mar 18, 2025
3f81844 to
8c89991
Compare
|
/test |
giorio94
approved these changes
Mar 19, 2025
This commit extends the conn-disrupt-test to ensure that connections through a Egress Gateway are not disrupted. The test deploys a conn-disrupt-test server with a single replica on an external node, a client on a gateway node and another client on a non gateway node. Clients establish long-lived TCP connections with the server through the gateway node. After upgrade, the test checks the restart counters, and compares them with the counters stored before the upgrade. A mismatch indicates that a connection was interrupted. Example output from `kubectl -n cilium-test-1 get po -o wide`: ``` NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES test-conn-disrupt-client-egw-gw-node-859d6b6875-vkvh2 1/1 Running 0 15s 10.244.3.206 kind-worker <none> <none> test-conn-disrupt-client-egw-non-gw-node-6c69d885df-7z6c5 1/1 Running 0 15s 10.244.1.14 kind-worker2 <none> <none> test-conn-disrupt-server-egw-644f65cb-vz8v7 1/1 Running 0 17s 172.18.0.4 kind-worker3 <none> <none> ``` Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
This commit enables conn-disrupt-test for Egress Gateway. Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
Restarting the agent disrupts the connection through the EGW when lb-acceleration is enabled due to #37431 Let's skip it for now Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
Currently, the cross-cluster EGW policies are not supported. Let's skip it for now. Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
8c89991 to
656594e
Compare
|
/test |
|
@pippolo84 Gentle ping for review🙏 |
Sorry for the delay, I'm gonna review this tomorrow 👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the conn-disrupt-test to ensure that connections through a Egress Gateway are not disrupted.
The test deploys a conn-disrupt-test server with a single replica on an external node, a client on a gateway node and another client on a non gateway node. Clients establish long-lived TCP connections with the server through the gateway node.
After upgrade, the test checks the restart counters, and compares them with the counters stored before the upgrade. A mismatch indicates that a connection was interrupted.
Example output from
kubectl -n cilium-test-1 get po -o wide:Fixes: #37092