Skip to content

gateway-api: Add docs for GatewayClass parameters #37821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

gateway-api: Add docs for GatewayClass parameters #37821

merged 1 commit into from
Feb 26, 2025

Conversation

sayboras
Copy link
Member

Relates: #37402, #37700

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 24, 2025
This was referenced Feb 18, 2025
Open
Open
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 24, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 24, 2025
@sayboras sayboras force-pushed the pr/tammach/cgwc-docs branch from 8eb84ac to 1e4801a Compare February 24, 2025 06:58
@sayboras sayboras marked this pull request as ready for review February 24, 2025 06:59
@sayboras sayboras requested review from a team as code owners February 24, 2025 06:59
qmonnet
qmonnet approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the use on the term “alpha” below, but this is not blocking, PR looks good to me. Thanks!

@qmonnet
Copy link
Member

qmonnet commented Feb 24, 2025

From the PRs you link to, I understand the feature is new and the docs don't need to be backported, right?

@qmonnet
Copy link
Member

qmonnet commented Feb 24, 2025

/test

@qmonnet qmonnet added release-note/misc This PR makes changes that have no direct user impact. feature/k8s-gateway-api and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 24, 2025
@qmonnet
Copy link
Member

qmonnet commented Feb 24, 2025

I changed the release-note label to misc, as this PR is only a documentation change.

@sayboras
Copy link
Member Author

From the PRs you link to, I understand the feature is new and the docs don't need to be backported, right?

It's correct 👍

I changed the release-note label to misc, as this PR is only a documentation change.

Thanks

youngnick
youngnick approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small update to the alpha caveat.

@sayboras sayboras force-pushed the pr/tammach/cgwc-docs branch from 1e4801a to f9dcb1a Compare February 25, 2025 04:03
@sayboras
Copy link
Member Author

/test

@sayboras
gateway-api: Add docs for GatewayClass parameters
58f2e2d 
Relates: #37402, #37700
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/cgwc-docs branch from f9dcb1a to 58f2e2d Compare February 25, 2025 11:01
@sayboras sayboras enabled auto-merge February 25, 2025 21:19
@sayboras sayboras added this pull request to the merge queue Feb 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 26, 2025
Merged via the queue into main with commit 6f434a4 Feb 26, 2025
281 checks passed
@sayboras sayboras deleted the pr/tammach/cgwc-docs branch February 26, 2025 09:29
@sayboras sayboras added the affects/v1.17 This issue affects v1.17 branch label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@youngnick youngnick youngnick approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
affects/v1.17 This issue affects v1.17 branch feature/k8s-gateway-api ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayboras @qmonnet @joamaki @youngnick