Revert "cli: Use error def of github.com/cilium/ebpf" #37687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1037713. The commit was fine and well-intentioned, but it introduced a hard dependency from the CLI onto cilium/ebpf library. The CLI is intended as a tool to run on user systems, not the target system. Introducing a dependency on libraries that directly interface with ebpf causes trouble because it means that cilium/ebpf must stub out all declarations on all platforms, even ones that don't make sense because the platform doesn't have ebpf support. So, rather than depending on this library just to do some substring matches, just retain the copies of the strings in the CLI and make the comparisons without the library. Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
asauber
approved these changes
Feb 17, 2025
|
Filed #37689 for the failure as it is unrelated to the changes in this PR. |
viktor-kurchenko
approved these changes
Feb 18, 2025
michi-covalent
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1037713.
The commit was fine and well-intentioned, but it introduced a hard
dependency from the CLI onto cilium/ebpf library. The CLI is intended as
a tool to run on user systems, not the target system. Introducing a
dependency on libraries that directly interface with ebpf causes trouble
because it means that cilium/ebpf must stub out all declarations on all
platforms, even ones that don't make sense because the platform doesn't
have ebpf support.
So, rather than depending on this library just to do some substring
matches, just retain the copies of the strings in the CLI and make the
comparisons without the library.
Related: #37598