Skip to content

Test IPv4 and IPv6 explicitly in PodToWorld connectivity tests #37435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

Test IPv4 and IPv6 explicitly in PodToWorld connectivity tests #37435

merged 3 commits into from
Mar 20, 2025

Conversation

gentoo-root
Copy link
Contributor

@gentoo-root gentoo-root commented Feb 4, 2025 •
edited
Loading

Fixes: #37139

Test IPv4 and IPv6 explicitly in PodToWorld and PodToWorld2 connectivity tests

@gentoo-root gentoo-root added the release-note/misc This PR makes changes that have no direct user impact. label Feb 4, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 4, 2025
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root force-pushed the pr/max/ipv6-tests branch 2 times, most recently from aee87b4 to a745b67 Compare February 6, 2025 13:05
@gentoo-root gentoo-root mentioned this pull request Feb 6, 2025
Merged
@gentoo-root gentoo-root force-pushed the pr/max/ipv6-tests branch 2 times, most recently from 02cd36f to d67dd41 Compare February 7, 2025 22:18
@julianwiedmann julianwiedmann self-requested a review February 13, 2025 12:37
@gentoo-root gentoo-root mentioned this pull request Feb 19, 2025
Merged
@gentoo-root gentoo-root force-pushed the pr/max/ipv6-tests branch 3 times, most recently from 7f4316d to 72d8871 Compare March 19, 2025 14:07
@gentoo-root
cilium-cli: Use k8s.io for connectivity tests
d1a1c05 
Change ExternalOtherTarget from cilium.io to k8s.io, because cilium.io
doesn't support IPv6 (doesn't have an AAAA record).

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root
cilium-cli: Explicitly test IPv4/IPv6 in PodToWorld and PodToWorld2 t…
6266976 
…ests

Test both IPv4 and IPv6, instead of one arbitrary address family
selected automatically.

Fixes: #37139
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root
cilium-cli: Disable IPv6 in PodToWorld and PodToWorld2 tests
d8dba69 
The previous commit ensures that PodToWorld and PodToWorld2 tests test
IPv6 explicitly, but the new test can't be enabled in the CI at the
moment, because it requires a kernel patch and a way to connect to
external IPv6 servers in the CI.

Disable the new test until the above issues are resolved.

Ref: #37932
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root changed the title Test IPv4 and IPv6 explicitly in connectivity tests Test IPv4 and IPv6 explicitly in PodToWorld connectivity tests Mar 19, 2025
@gentoo-root gentoo-root marked this pull request as ready for review March 19, 2025 23:03
@gentoo-root gentoo-root requested review from a team as code owners March 19, 2025 23:03
@gentoo-root gentoo-root requested a review from mhofstetter March 19, 2025 23:03
mhofstetter
mhofstetter approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

julianwiedmann
julianwiedmann reviewed Mar 20, 2025
View reviewed changes
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 20, 2025
@julianwiedmann julianwiedmann added the feature/ipv6 Relates to IPv6 protocol support label Mar 20, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 09b3cd8 Mar 20, 2025
221 of 223 checks passed
@julianwiedmann julianwiedmann deleted the pr/max/ipv6-tests branch March 20, 2025 17:20
@julianwiedmann julianwiedmann mentioned this pull request Mar 21, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann left review comments

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary feature/ipv6 Relates to IPv6 protocol support ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit IPv6 testing to PodToWorld and PodToWorld2 cilium-cli connectivity test scenarios
3 participants
@gentoo-root @mhofstetter @julianwiedmann