Skip to content

fix: Hubble metrics not deleted for deleted pods #36819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: Hubble metrics not deleted for deleted pods #36819

merged 1 commit into from
Jan 14, 2025

Conversation

rectified95
Copy link
Contributor

@rectified95 rectified95 commented Jan 2, 2025 •
edited
Loading

The function that deletes metrics for deleted pods isn't getting called due to a mistake in previous refactoring.
Instead, the code that posts the deletion in a queue calls itself in a loop.

Fixes #36195

@rectified95 rectified95 requested a review from a team as a code owner January 2, 2025 21:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 2, 2025
rectified95
rectified95 commented Jan 2, 2025
View reviewed changes
@rectified95 rectified95 changed the title Move ProcessCiliumEndpointDeletion to test folder of metrics/api. fix: Hubble metrics not deleted for deleted pods Jan 6, 2025
@rectified95
Copy link
Contributor Author

/test

@chancez chancez added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Jan 7, 2025
@rectified95
Copy link
Contributor Author

/test

@rectified95
fix: metrics not removed on pod delete
b70638e 
Signed-off-by: Igor Klemenski <igor.klemenski@microsoft.com>
@rolinh rolinh added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Jan 10, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 10, 2025
@rolinh
Copy link
Member

rolinh commented Jan 10, 2025

/test

1 similar comment
@rectified95
Copy link
Contributor Author

/test

@rectified95
Copy link
Contributor Author

/ci-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 13, 2025
@rolinh rolinh added this pull request to the merge queue Jan 14, 2025
Merged via the queue into cilium:main with commit d7789d7 Jan 14, 2025
64 checks passed
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
Merged
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 22, 2025
@cilium-release-bot cilium-release-bot bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez chancez approved these changes

Assignees
No one assigned
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Hubble metrics api package
4 participants
@rectified95 @rolinh @chancez @rastislavs