Skip to content

images: Update LLVM to 18.1.8 #36197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

images: Update LLVM to 18.1.8 #36197

merged 3 commits into from
Nov 27, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 27, 2024

Relates: cilium/image-tools#302
Relates: #32801

@maintainer-s-little-helper
Copy link

Commit a344fe5 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 27, 2024
@sayboras sayboras requested a review from gentoo-root November 27, 2024 03:17
Relates: cilium/image-tools#302
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/llvm-18.1.8 branch from a344fe5 to 25d5abe Compare November 27, 2024 03:18
@maintainer-s-little-helper
Copy link

Commit a344fe5 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@sayboras sayboras temporarily deployed to release-base-images November 27, 2024 03:18 — with GitHub Actions Inactive
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2024
@sayboras sayboras removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 27, 2024
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@auto-committer auto-committer bot temporarily deployed to release-base-images November 27, 2024 03:45 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images November 27, 2024 03:54 Inactive
@sayboras
Copy link
Member Author

/test

This is to avoid the below issue while running integration tests.

```
clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras temporarily deployed to release-base-images November 27, 2024 04:34 — with GitHub Actions Inactive
@sayboras sayboras temporarily deployed to release-base-images November 27, 2024 04:35 — with GitHub Actions Inactive
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review November 27, 2024 07:05
@sayboras sayboras requested review from a team as code owners November 27, 2024 07:05
@sayboras sayboras requested review from kaworu and brlbil November 27, 2024 07:05
@julianwiedmann julianwiedmann added area/llvm Requires upstream work in LLVM. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Nov 27, 2024
@sayboras sayboras enabled auto-merge November 27, 2024 09:57
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relay change LGTM

@sayboras sayboras added this pull request to the merge queue Nov 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 27, 2024
Merged via the queue into main with commit 083a442 Nov 27, 2024
297 of 298 checks passed
@sayboras sayboras deleted the pr/tammach/llvm-18.1.8 branch November 27, 2024 16:24
@julianwiedmann
Copy link
Member

@sayboras can we close #32801 then, or are there still any outstanding tasks for the update to LVVM 18?

I remember @gentoo-root did an evaluation of BPF program size / complexity changes when we last bumped to LLVM 17, to identify gains / regressions.

@sayboras
Copy link
Member Author

yes, it will be the next step 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/llvm Requires upstream work in LLVM. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants