Skip to content

LLVM 18 fixes batch #3 #35590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

LLVM 18 fixes batch #3 #35590

merged 1 commit into from
Oct 29, 2024

Conversation

gentoo-root
Copy link
Contributor

Ref: #32801
Ref: #32816

Improve compatibility with LLVM 18.

@gentoo-root
bpf: Add missing __align_stack_8 in encap_geneve_dsr_opt4
f788478 
LLVM 18 doesn't align these structs to 8 by default, and our memcpy
implementation fails to pass the verifier when applied to these structs,
because the verifier requires stack access to be aligned. Align all
affected structs.

Ref: 4853fb1 ("bpf: Use __align_stack_8 on IPv6 structs")
Fixes: c6a2836 ("bpf: dsr: refactor encap_geneve_dsr_opt()")
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 28, 2024
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root added area/llvm Requires upstream work in LLVM. release-note/misc This PR makes changes that have no direct user impact. labels Oct 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 28, 2024
@gentoo-root gentoo-root marked this pull request as ready for review October 28, 2024 13:05
@gentoo-root gentoo-root requested a review from a team as a code owner October 28, 2024 13:05
@gentoo-root gentoo-root requested a review from ldelossa October 28, 2024 13:05
ldelossa
ldelossa approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 29, 2024
@julianwiedmann julianwiedmann added the area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Oct 29, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 783648c Oct 29, 2024
286 checks passed
@julianwiedmann julianwiedmann deleted the pr/max/llvm18-fixes branch October 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/llvm Requires upstream work in LLVM. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gentoo-root @ldelossa @julianwiedmann