fqdn: Skip "open ports" check for statically configured ports #33230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
6ba233a to
0c589af
Compare
christarazi
approved these changes
Jun 18, 2024
0c589af to
a394dc1
Compare
When restoring the previous DNS proxy port, we check if the port is already in-use. However, if the port we retrieved from `GetProxyPort` was previously set via `SetProxyPort`, then we want to use it unconditionally. We rely on `isStatic` for this, as static ports cannot change and the open port may be open with `SO_REUSEPORT` (which `proxy.OpenLocalPorts()` does not check). Restored ports never have `isStatic` set to true, so this does retain the "open ports" check if the port was restored. In addition, when restoring ports we want to make sure that previous calls to `SetProxyPort` are also not overwritten, thus this commit also only restores the port if it wasn't explicitly set. This is the same behavior we had previously, which did not check the returned port of `d.l7Proxy.GetProxyPort` against the list of open ports. Fixes: d11e4d2 ("proxy: Reuse proxy ports from datapath on restart") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
a394dc1 to
47f1467
Compare
|
/test |
|
CI is green except for #33257 which is expected. Merging. |
This was referenced Nov 6, 2024
|
The "Fixed" commit was backported to stable branches. This means we need to backport this too. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring the previous DNS proxy port, we check if the port is
already in-use. However, if the port we retreived from
GetProxyPortwas previously set via
SetProxyPort, then we want to use itunconditionally. We rely on
isStaticfor this, as as static portscannot change and the open port may be open with
SO_REUSEPORT(whichproxy.OpenLocalPorts()does not check). Restored ports never haveisStaticset to true, so this does retain the "open ports" check ifthe port was restored.
In addition, when restoring ports we want to make sure
that previous calls to
SetProxyPortare also not overwritten, thusthis commit also only restores the port if it wasn't explicitly set.
This is the same behavior we had previously, which did not check the
returned port of
d.l7Proxy.GetProxyPortagainst the list of openports.
Fixes: d11e4d2 ("proxy: Reuse proxy ports from datapath on restart")