Skip to content

LLVM 18 fixes batch #1 #32918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2024
Merged

LLVM 18 fixes batch #1 #32918

merged 2 commits into from
Jun 7, 2024

Conversation

gentoo-root
Copy link
Contributor

Ref: #32801
Ref: #32816

Improve compatibility with LLVM 18.

@gentoo-root
Remove the unused LPM_LOOKUP_FN macro
c61b59b 
Since commit 7628b19 ("bpf, ipcache: unconditionally assume support
for LPM trie maps"), LPM_LOOKUP_FN is only used in its own test. Remove
the macro and the test, as it's not used in any actual code, and it
causes verifier errors when upgrading to LLVM 18: the verifier can't
track a pointer spilled to a map (a global variable).

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root
bpf: Use __align_stack_8 on IPv6 structs
9183836 
LLVM 18 doesn't align these structs to 8 by default, and our memcpy
implementation fails to pass the verifier when applied to these structs,
because the verifier requires stack access to be aligned. Align all
affected structs.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root gentoo-root requested a review from a team as a code owner June 5, 2024 15:41
@gentoo-root gentoo-root requested a review from jibi June 5, 2024 15:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 5, 2024
@gentoo-root gentoo-root added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 5, 2024
@gentoo-root
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2024
@borkmann borkmann merged commit 4853fb1 into main Jun 7, 2024
@borkmann borkmann deleted the pr/max/llvm18-fixes branch June 7, 2024 07:33
@julianwiedmann julianwiedmann added the area/llvm Requires upstream work in LLVM. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

Assignees
No one assigned
Labels
area/llvm Requires upstream work in LLVM. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gentoo-root @jibi @borkmann @julianwiedmann