cleanup: untangle unnecessarily complex policy initialization #32813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn3r
approved these changes
May 31, 2024
|
/test |
doniacld
approved these changes
Jun 4, 2024
aditighag
approved these changes
Jun 4, 2024
|
(Sorry for the delay.) |
|
/test |
We no longer allocate identities in the SelectorCache; stop plumbing it through. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
This utility type doesn't belong in an implementation package. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
The dependencies aren't actually as complicated as the code makes them out to be. We can construct them iteratively without mutation, now that we no longer need the cache to list reserved identities. This is a no-op change. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
I commented it out but forgot to remove it in a prior PR. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
ba45026 to
acd565e
Compare
|
/test |
1 similar comment
|
/test |
|
I have rebased with main branch to pick up the below CI fix. |
1 task
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jun 17, 2024
Update cilium to pick up cilium/cilium#32813. Ref: #2599 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jun 17, 2024
Update cilium to pick up cilium/cilium#32813. Ref: #2599 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
sayboras
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
Jun 17, 2024
Update cilium to pick up cilium/cilium#32813. Ref: #2599 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
policy.NewPolicyRepository()took a reference to an ID allocator, but it only used this to determine the initial set of identities. This funny little parameter created a circular reference that is tricky to untangle during initialization.We can remove this; the initial set of identities is well known and we don't need to create the allocator just to provide that parameter.
So, remove unnecessary parameters and un-circular-ize the policy cell initialization.