Skip to content

Ginkgo: Add verbose mode in Ginkgo #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2018
Merged

Ginkgo: Add verbose mode in Ginkgo #2599

merged 2 commits into from
Jan 22, 2018

Conversation

eloycoto
Copy link
Member

  • Add the verbose mode in Ginkgo to dump all logs output into the
    console, command example:
ginkgo --focus "Runtime*" -v
  • Clean test_results directory before start

Signed-off-by: Eloy Coto eloy.coto@gmail.com

@eloycoto eloycoto added pending-review area/CI Continuous Integration testing issue or flake labels Jan 22, 2018
@eloycoto eloycoto requested a review from a team January 22, 2018 12:46
@eloycoto
Copy link
Member Author

test-all-ginkgo

@eloycoto
Copy link
Member Author

test-all-ginkgo

@eloycoto
Copy link
Member Author

test-me-please

@ianvernon
Copy link
Member

Change looks good; this sort of flexibility will be very helpful for local debugging! Can you please update the documentation in Documentation/contributing.rst to reflect this new default configuration, (i.e., remove the -v flag from example commands), and update the documentation under Available CLI Options to explain what this option does.

@eloycoto eloycoto requested a review from a team as a code owner January 22, 2018 18:46
@eloycoto
Ginkgo: Add verbose mode in Ginkgo
a8b9512 
- Add the verbose mode in Ginkgo to dump all logs output into the
console, command example:
```
ginkgo --focus "Runtime*" -v
```
- Clean `test_results` directory before start

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
@eloycoto
Doc: Added ginkgo debugging section
846a391 
Added ginkgo debug section

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
@eloycoto
Copy link
Member Author

@ianvernon should be ok now :-)

@eloycoto
Copy link
Member Author

test-me-please

ianvernon
ianvernon approved these changes Jan 22, 2018
View reviewed changes
Documentation/contributing.rst
Kubernetes APIs: [""]
Cilium: Ok OK
NodeMonitor: Disabled
Allocated IPv4 addresses:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Approved :D

@tgraf tgraf merged commit 41b47f2 into cilium:master Jan 22, 2018
@eloycoto eloycoto mentioned this pull request Jan 23, 2018
Closed
2 tasks
michi-covalent added a commit that referenced this pull request Jul 16, 2024
@michi-covalent
Pick up the latest cilium/cilium from main branch
7536f8f 
Update cilium to pick up #32813.

Ref: #2599

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent added a commit that referenced this pull request Aug 5, 2024
@michi-covalent
Pick up the latest cilium/cilium from main branch
7c9df62 
[ cherry-picked from cilium/cilium-cli repository ]

Update cilium to pick up #32813.

Ref: #2599

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2024
@michi-covalent
Pick up the latest cilium/cilium from main branch
bcdf8d8 
[ cherry-picked from cilium/cilium-cli repository ]

Update cilium to pick up #32813.

Ref: #2599

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

@ianvernon ianvernon ianvernon approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eloycoto @ianvernon @tgraf