Skip to content

pkg/fqdn: Replace remaining usages of regex compile with LRU #19875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

pkg/fqdn: Replace remaining usages of regex compile with LRU #19875

merged 1 commit into from
May 30, 2022

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented May 18, 2022 •
edited
Loading

Fixes: 8761498 ("fqdn: Use new regex LRU package everywhere")

Signed-off-by: Chris Tarazi chris@isovalent.com

Related: #19632

@christarazi christarazi added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. kind/performance There is a performance impact of this. release-note/misc This PR makes changes that have no direct user impact. labels May 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 18, 2022
@christarazi
Copy link
Member Author

/test

@christarazi christarazi marked this pull request as ready for review May 18, 2022 22:49
@christarazi christarazi requested review from a team and tommyp1ckles May 18, 2022 22:49
@christarazi
pkg/fqdn: Replace remaining usages of regex compile with LRU
995cab7 
Fixes: 8761498 ("fqdn: Use new regex LRU package everywhere")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Copy link
Member Author

CI passed except for legit Travis failure. Pushing to fix Travis failure.

@christarazi christarazi force-pushed the pr/christarazi/fqdn-lru-followup branch from adf5978 to 995cab7 Compare May 20, 2022 00:49
@christarazi
Copy link
Member Author

Marking ready to merge as we have approved review and CI passed.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 28, 2022
@jibi jibi merged commit 2e0d591 into cilium:master May 30, 2022
@christarazi christarazi deleted the pr/christarazi/fqdn-lru-followup branch May 30, 2022 21:44
@joamaki joamaki mentioned this pull request Jun 8, 2022
Merged
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 9, 2022
@joestringer joestringer mentioned this pull request Jun 13, 2022
Merged
@aanm aanm mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christarazi @tommyp1ckles @jibi @joamaki @joestringer