Skip to content

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Sep 7, 2020

The bandwidth test is failing in master and PRs because the measured rate-limited bandwidth sometimes falls outside the accepted range.

The accepted range is [20; 30] and values sampled from failing tests are 19.92, 19.73, 19.38, 19, 19.88, 19.94, etc. Thus, increasing the range to [18; 32] should be enough to prevent further flakes.

Fixes: #13062

The bandwidth test is failing in master and PRs because the measured
rate-limited bandwidth sometimes falls outside the accepted range.

The accepted range is [20; 30] and values sampled from failing tests
are 19.92, 19.73, 19.38, 19, 19.88, 19.94, etc. Thus, increasing the
range to [18; 32] should be enough to prevent further flakes.

Fixes: #13062
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Sep 7, 2020
@pchaigno pchaigno requested a review from borkmann September 7, 2020 09:57
@pchaigno pchaigno requested a review from a team as a code owner September 7, 2020 09:57
@pchaigno
Copy link
Member Author

pchaigno commented Sep 7, 2020

test-me-please

@brb brb merged commit 336773a into master Sep 8, 2020
@brb brb deleted the pr/pchaigno/increase-accepted-range-bandwidth-test branch September 8, 2020 13:27
@borkmann borkmann added the feature/bandwidth-manager Impacts BPF bandwidth manager. label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! feature/bandwidth-manager Impacts BPF bandwidth manager. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: K8sBandwidthTest Checks Bandwidth Rate-Limiting Checks Pod to Pod bandwidth
4 participants