Skip to content

Conversation

raybejjani
Copy link
Contributor

@raybejjani raybejjani commented Feb 11, 2020

v1.5 backports 2020-02-11

Once this PR is merged, you can update the PR labels via:

$ for pr in 9034 10035 10066; do contrib/backporting/set-labels.py $pr done 1.5; done

@aanm I had to apply #10035 by hand and I skipped "contributing/release: fix typo in stable release process" and "contributing/release: remove Update versions step".
@nebril I skipped #10062


This change is Reviewable

jrfastab and others added 4 commits February 11, 2020 11:07
[ upstream commit ef01850 ]

When running with a kernel that has IPv6 compiled out there is no
/proc/net/ipv6/ directory so trying to enable IPv6 fails and the
daemon can not start.

To resolve this only enable IPv6 forwarding when daemon is running with
IPv6 enabled.

Error seen with IPv6 compiled out and IPv6 disabled in config map is

level=fatal msg="Error when enabling sysctl parameters" error="could not open the sysctl file /proc/sys/net/ipv6/conf/all/forwarding: open /proc/sys/net/ipv6/conf/all/forwarding: no such file or directory" subsys=daemon

Fixes: 294cf66 ("daemon: Enable IP forwarding on start")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit c644a11 ]

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit 6c14163 ]

We will include the automated release notes generated in the Github
release page.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit dec65a6 ]

`git shortlog v1.0.2..` can be executed by anyone in their terminal and
since we now have auto-generated release-notes it does not make sense to
run this step anymore.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Ray Bejjani <ray@isovalent.com>
@raybejjani raybejjani added kind/backports This PR provides functionality previously merged into master. backport/1.5 labels Feb 11, 2020
@raybejjani raybejjani requested a review from a team as a code owner February 11, 2020 11:26
@raybejjani
Copy link
Contributor Author

never-tell-me-the-odds

[ upstream commit 4890a15 ]

It has been observed that kubelet calls CNI DELETE multiple times with
potentially stale CNI result information. This can lead to a race condition
where the initial CNI DELETE properly releases the IP in use which then gets
reused by a different pod. Any subsequent CNI DELETE with the stale IP will
then cause the IP of the live pod to be released. While the pod will continue
to function, the next scheduled pod will attempt to use that IP and
continuously fail to be scheduled due to a IP in use error.

This is a regression of commit ab61853 which introduced the ability for CNI
DELETE to release an IP even if the endpoint deletion fails which is required
to fix the race condition when the CNI binary gets killed in between allocating
an IP and creating the endpoint.

Fixes: ab61853 ("cni: Release IP even when endpoint deletion fails")
Fixes: #10065

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Ray Bejjani <ray@isovalent.com>
@raybejjani raybejjani force-pushed the pr/v1.5-backport-2020-02-11 branch from 21577a8 to b6ea471 Compare February 11, 2020 13:51
@raybejjani
Copy link
Contributor Author

never-tell-me-the-odds

@aanm
Copy link
Member

aanm commented Feb 11, 2020

test-me-please (some istio fail. probably a flake https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/2834/)

@aanm
Copy link
Member

aanm commented Feb 11, 2020

test-upstream-k8s (vagrant timeout https://jenkins.cilium.io/job/Cilium-PR-Kubernetes-Upstream/1883/)

@raybejjani
Copy link
Contributor Author

test-me-please

@raybejjani
Copy link
Contributor Author

test-upstream-k8s

@aanm
Copy link
Member

aanm commented Feb 11, 2020

test-missed-k8s

@aanm aanm merged commit 0f07953 into v1.5 Feb 12, 2020
@aanm aanm deleted the pr/v1.5-backport-2020-02-11 branch February 12, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants