-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.5 backport 2020 02 11 #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v1.5 backport 2020 02 11 #10136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit ef01850 ] When running with a kernel that has IPv6 compiled out there is no /proc/net/ipv6/ directory so trying to enable IPv6 fails and the daemon can not start. To resolve this only enable IPv6 forwarding when daemon is running with IPv6 enabled. Error seen with IPv6 compiled out and IPv6 disabled in config map is level=fatal msg="Error when enabling sysctl parameters" error="could not open the sysctl file /proc/sys/net/ipv6/conf/all/forwarding: open /proc/sys/net/ipv6/conf/all/forwarding: no such file or directory" subsys=daemon Fixes: 294cf66 ("daemon: Enable IP forwarding on start") Signed-off-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit c644a11 ] Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit 6c14163 ] We will include the automated release notes generated in the Github release page. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Ray Bejjani <ray@isovalent.com>
[ upstream commit dec65a6 ] `git shortlog v1.0.2..` can be executed by anyone in their terminal and since we now have auto-generated release-notes it does not make sense to run this step anymore. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Ray Bejjani <ray@isovalent.com>
never-tell-me-the-odds |
[ upstream commit 4890a15 ] It has been observed that kubelet calls CNI DELETE multiple times with potentially stale CNI result information. This can lead to a race condition where the initial CNI DELETE properly releases the IP in use which then gets reused by a different pod. Any subsequent CNI DELETE with the stale IP will then cause the IP of the live pod to be released. While the pod will continue to function, the next scheduled pod will attempt to use that IP and continuously fail to be scheduled due to a IP in use error. This is a regression of commit ab61853 which introduced the ability for CNI DELETE to release an IP even if the endpoint deletion fails which is required to fix the race condition when the CNI binary gets killed in between allocating an IP and creating the endpoint. Fixes: ab61853 ("cni: Release IP even when endpoint deletion fails") Fixes: #10065 Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Ray Bejjani <ray@isovalent.com>
21577a8
to
b6ea471
Compare
never-tell-me-the-odds |
test-me-please (some istio fail. probably a flake https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/2834/) |
test-upstream-k8s (vagrant timeout https://jenkins.cilium.io/job/Cilium-PR-Kubernetes-Upstream/1883/) |
test-me-please |
test-upstream-k8s |
test-missed-k8s |
aanm
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.5 backports 2020-02-11
[CI] add release name to helm template calls #10062 -- [CI] add release name to helm template calls (@nebril)Once this PR is merged, you can update the PR labels via:
@aanm I had to apply #10035 by hand and I skipped "contributing/release: fix typo in stable release process" and "contributing/release: remove Update versions step".
@nebril I skipped #10062
This change is