cilium: only enable IPv6 forwarding if IPv6 is enabled #9034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with a kernel that has IPv6 compiled out there is no /proc/net/ipv6/ directory so trying to enable IPv6 fails and the daemon can not start. To resolve this only enable IPv6 forwarding when daemon is running with IPv6 enabled. Error seen with IPv6 compiled out and IPv6 disabled in config map is level=fatal msg="Error when enabling sysctl parameters" error="could not open the sysctl file /proc/sys/net/ipv6/conf/all/forwarding: open /proc/sys/net/ipv6/conf/all/forwarding: no such file or directory" subsys=daemon Fixes: 294cf66 ("daemon: Enable IP forwarding on start") Signed-off-by: John Fastabend <john.fastabend@gmail.com>
|
test-me-please |
tgraf
approved these changes
Aug 25, 2019
|
any chance of this being backported to cilium 1.6.x? |
|
Added label, thanks for reporting @jdef |
|
@raybejjani same here update tags ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with a kernel that has IPv6 compiled out there is no
/proc/net/ipv6/ directory so trying to enable IPv6 fails and the
daemon can not start.
To resolve this only enable IPv6 forwarding when daemon is running with
IPv6 enabled.
Error seen with IPv6 compiled out and IPv6 disabled in config map is
level=fatal msg="Error when enabling sysctl parameters" error="could not open the sysctl file /proc/sys/net/ipv6/conf/all/forwarding: open /proc/sys/net/ipv6/conf/all/forwarding: no such file or directory" subsys=daemon
Fixes: 294cf66 ("daemon: Enable IP forwarding on start")
Signed-off-by: John Fastabend john.fastabend@gmail.com
This change is