Issue #16786: Ensure enum constants accessibility is properly evaluated (addressing JavadocVariableCheck _only_)
#17112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
May 21, 2025
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocVariableCheck.java
Outdated
Show resolved
Hide resolved
|
As changes will be cosmetic, I am starting diff testing. |
|
Github, generate report for JavadocVariable/all-examples-in-one |
|
Report for JavadocVariable/all-examples-in-one: |
|
No diff with report on previous PR https://www.diffchecker.com/z9ZP4ZZt/ I would rather merge this PR. |
d9a4633 to
fb4072b
Compare
✅ |
kkoutsilis
approved these changes
May 21, 2025
devOpsHazelcast
pushed a commit
to hazelcast/hazelcast
that referenced
this pull request
May 22, 2025
[A bug was introduced in checkstyle](checkstyle/checkstyle#16786) that [blocked us from upgrading](https://github.com/hazelcast/hazelcast-mono/pull/4142#pullrequestreview-2746790707). Although this is [now fixed](checkstyle/checkstyle#17112), [they have asked](c4ed533#r157717810) if the version of checkstyle used could be externalised to allow the codebase to be used as part of testing new checkstyle versions. GitOrigin-RevId: 329a865e27e6aecaa56d74a44a170db1a8df9d8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends change in #16049, in the case of an enum constant, it's accessibility will be derived based on the enclosing enum (which could be
private) rather than being assumed to be implicitly public.Test(s) added to validate.
Fixes: #16786
Closes: #16787
This is alternative implementation of #16787, but affecting only
JavadocVariableCheckto address concerns.