fix: mkdir parent db directory #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #549
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the CACHE/conversations directory is created at startup and fixes how the cache path is displayed.
- Switched from printing the parent directory of
CachePathto printing the fullCachePath - Updated
ensureConfigto create theconversationssubfolder under the cache directory
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.go | Print the actual cache path instead of its parent |
| config.go | Use os.MkdirAll to create CACHE/conversations |
Comments suppressed due to low confidence (2)
config.go:237
- [nitpick] The error message "Could not create cache directory." may be misleading since this is specifically creating the "conversations" subdirectory. Consider updating it to reference the full path or mention "conversations" explicitly.
filepath.Join(c.CachePath, "conversations"),
config.go:236
- Add a unit test to verify that
ensureConfigactually creates theconversationsdirectory underCachePath, preventing future regressions.
if err := os.MkdirAll(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #549
make sure the
CACHE/conversationsdir is created as well