fix: disable background check for completion cmd #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A common way to source completions from CLIs is using process subsitution like this:
This does however not work currently in fang, because it opens stdin to check background color.
To reproduce the issue:
This hangs forever.
The proposed fix just checks to see if the command we're executing is the completion command, in which case the style / background color does not matter anyways and it skips the check.
Another (probably better) way to fix this would be to detect if we're piping (if that's possible) and not open stdin in that case.
Related issue/discussion:
Checklist before requesting a review
CONTRIBUTING.md