fix: don't detect background color if output's not a tty #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses broken output issues by preventing background color detection when the output is not a TTY. Key changes include an upgrade of the golang.org/x/sys dependency in go.mod and a conditional check in fang.go to only detect dark backgrounds if stdout is a TTY.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Upgraded golang.org/x/sys from v0.31.0 to v0.33.0 for compatibility with TTY handling improvements. |
| fang.go | Added a conditional check using term.IsTerminal to guard background color detection. |
Comments suppressed due to low confidence (1)
go.mod:33
- Ensure that the dependency upgrade to v0.33.0 of golang.org/x/sys is compatible with the rest of the codebase, particularly regarding terminal handling improvements.
golang.org/x/sys v0.33.0 // indirect
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken output when no TTY is present.
Fixes #34
Supersedes #31