Skip to content

Clarify project details #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Clarify project details #61

merged 1 commit into from
Jul 3, 2025

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jun 26, 2025 •
edited
Loading

Description

  • Add History section
  • Add info about releases as tags only
  • Add info about binaries from Chainguard and build your own
  • Update changelog

Signed-off-by : Manfred Moser manfred@simpligility.ca

I think this provides a good base for the project going forward. The following aspects could be discussed as next steps:

  • Presence on #kaniko on k8s slack needs to be clarified or maybe removed
  • Build instructions in general and specifically also for binaries need to be improved for DIYer, this might also require code updates
  • Other docs and scripts should be changed to no longer use gcr.io as container registry since these binaries are outdated and will no longer be updated.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

priyawadhwa
priyawadhwa reviewed Jun 27, 2025
View reviewed changes
cpanato
cpanato reviewed Jun 27, 2025
View reviewed changes
tonyjcamp
tonyjcamp reviewed Jun 27, 2025
View reviewed changes
Copy link

@tonyjcamp tonyjcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why "images" in this sentence is linked to the "releases" section:
kaniko is meant to be run as an image.

@mosabua mosabua force-pushed the status branch 2 times, most recently from 0480c64 to 68104d9 Compare June 27, 2025 19:17
@mosabua
Copy link
Member Author

mosabua commented Jun 27, 2025 •
edited
Loading

I'm not sure I understand why "images" in this sentence is linked to the "releases" section: kaniko is meant to be run as an image.

Because there is no such thing anymore as a static image name .. if uses build container image themselves they can use any name .. if they use chainguard the name will depend on their image and also their account name .. maybe we need a generic placeholder that replaces the old gcr.io/kaniko-project/executor and warmer.. which are now wrong and invalid since no new binaries are on gcr .. they are still only the old ones there and referencing them is misleading .. those details are all in the new section

@mosabua
Clarify project details
c1ed494 
- Add History section
- Add info about releases as tags only
- Add info about binaries from Chainguard and build your own
- Update changelog

Signed-off-by : Manfred Moser <manfred@simpligility.ca>
mzihlmann added a commit to mzihlmann/cg-kaniko that referenced this pull request Jun 28, 2025
@mzihlmann
Merge pull request chainguard-dev#61 from mzihlmann/dependabot/github…
b0fbe78 
…_actions/docker/setup-buildx-action-3.11.0

chore(deps): bump docker/setup-buildx-action from 3.10.0 to 3.11.0
@mosabua
Copy link
Member Author

mosabua commented Jul 2, 2025

Another look please @cpanato @priyawadhwa

@mosabua mosabua merged commit c0ff30d into chainguard-dev:main Jul 3, 2025
11 checks passed
@mosabua mosabua deleted the status branch July 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyjcamp tonyjcamp tonyjcamp left review comments

@priyawadhwa priyawadhwa priyawadhwa left review comments

@cpanato cpanato cpanato approved these changes

@ltagliaferri ltagliaferri Awaiting requested review from ltagliaferri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mosabua @tonyjcamp @cpanato @priyawadhwa