Add ability to trigger presubmits when named files change #111
Conversation
also adds licenses test Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
see cert-manager/release#111 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
There was a problem hiding this comment.
Thanks @SgtCoDFish
The results look good
Does the go.mod file contain all the dependencies?
Would the LICENCE file content change if the go.sum changed?
Could the go.sum file ever change independently of the go.mod file?
There do seem to be some additional dependencies that only exist in the go.sum file,
but I can't remember whether that means that those dependencies may not actually get compiled in to our binaries
$ diff -u <(awk '{print $1}' go.mod | sort | uniq) <(awk '{print $1}' go.sum | sort | uniq)
--- /dev/fd/63 2022-12-06 16:59:24.071971418 +0000
+++ /dev/fd/62 2022-12-06 16:59:24.072971415 +0000
@@ -1,9 +1,23 @@
-
-)
+cloud.google.com/go
+cloud.google.com/go/bigquery
cloud.google.com/go/compute
+cloud.google.com/go/datastore
+cloud.google.com/go/firestore
+cloud.google.com/go/iam
+cloud.google.com/go/pubsub
+cloud.google.com/go/storage
+dmitri.shuralyov.com/gpu/mtl
+github.com/agnivade/levenshtein
github.com/akamai/AkamaiOPEN-edgegrid-golang
+github.com/alecthomas/template
+github.com/alecthomas/units
+github.com/andreyvit/diff
+github.com/antihax/optional
+github.com/armon/circbuf
+github.com/armon/consul-api
github.com/armon/go-metrics
github.com/armon/go-radix
+github.com/armon/go-socks5
github.com/asaskevich/govalidator
github.com/aws/aws-sdk-go
github.com/Azure/azure-sdk-for-go
...
/lgtm
/hold in case you think these tests should also be triggered by changes to the go.sum file.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold I think it's reasonable for us to trigger only based on If we wanted to add go.sum in the future it'd not be hard! Thanks for the review! |
see cert-manager/release#111 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
see cert-manager/release#111 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
see cert-manager/release#111 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Also adds standalone licenses test; after this merges we can remove the licenses test from
ci-presubmit.