Skip to content

[release-1.17] fix: permit permitted URI domains in name constraints #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

[release-1.17] fix: permit permitted URI domains in name constraints #7832

merged 1 commit into from
Jun 30, 2025

Conversation

cert-manager-bot
Copy link
Contributor

This is an automated cherry-pick of #7816

/assign inteon

BUGFIX: permitted URI domains were incorrectly used to set the excluded URI domains in the CSR's name constraints

@kinolaev
fix: permit permitted URI domains in name constraints
ad07d81 
Signed-off-by: Sergei Nikolaev <kinolaev@gmail.com>
@cert-manager-bot cert-manager-bot mentioned this pull request Jun 30, 2025
Merged
@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2025
@erikgb erikgb requested a review from wallrj June 30, 2025 07:49
@inteon
Copy link
Member

inteon commented Jun 30, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@kinolaev
Copy link
Contributor

/kind bug

@cert-manager-prow cert-manager-prow bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 30, 2025
@cert-manager-prow cert-manager-prow bot merged commit 3f1f3b1 into cert-manager:release-1.17 Jun 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cert-manager-bot @inteon @kinolaev