Skip to content

fix(acmechallenges): increasing timeout #7796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

fix(acmechallenges): increasing timeout #7796

merged 2 commits into from
Jun 13, 2025

Conversation

hjoshi123
Copy link
Contributor

@hjoshi123 hjoshi123 commented Jun 12, 2025 •
edited by wallrj
Loading

Pull Request Motivation

#7337. Upon discussion on this issue, it was decided that we will bump up the timeout and check with our users to see if it fixes it. Then we would introduce a feature flag for a more long term fix.

Kind

/king bug

Release Note

ACME: Increased challenge authorization timeout to 2 minutes to fix `error waiting for authorization`

hjoshi123 added 2 commits June 12, 2025 11:08
@hjoshi123
increasing timeout based on discussions
0b1dad0 
Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>
@hjoshi123
removing period
da2884b 
Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>
@cert-manager-prow
Copy link
Contributor

@hjoshi123: The label(s) kind/release, kind/note cannot be applied, because the repository doesn't have them.

In response to this:

Pull Request Motivation

#7337. Upon discussion on this issue, it was decided that we will bump up the timeout and check with our users to see if it fixes it. Then we would introduce a feature flag for a more long term fix.

Kind

/king bug

/kind

Release Note

Changed `authorizationTimeout` to 2 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 12, 2025
@cert-manager-prow
Copy link
Contributor

Hi @hjoshi123. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2025
@erikgb
Copy link
Member

erikgb commented Jun 12, 2025

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2025
SgtCoDFish
SgtCoDFish approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you for this - Erik and Adam filled me in on the details of this and this seems like an excellent first step!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2025
@SgtCoDFish
Copy link
Member

/cherry-pick release-1.17

@cert-manager-bot
Copy link
Contributor

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish SgtCoDFish added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 13, 2025
@cert-manager-prow cert-manager-prow bot merged commit 21da5d7 into cert-manager:master Jun 13, 2025
6 checks passed
@cert-manager-bot
Copy link
Contributor

@SgtCoDFish: new pull request created: #7798

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Jun 13, 2025
Merged
@wallrj
Copy link
Member

wallrj commented Jun 13, 2025

/cherry-pick release-1.18

@cert-manager-bot
Copy link
Contributor

@wallrj: new pull request created: #7801

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Jun 13, 2025
Merged
This was linked to issues Jun 17, 2025
Using 1.16.0, the ACME issuer using HTTP-01 solver with Gateway API is broken #7337
Closed
non-acme api error: Context deadline exeeced #7444
Closed
ACME GCP CA - Error waiting for authorization #7685
Closed
@wallrj
Copy link
Member

wallrj commented Jun 18, 2025

📢 This has been released in cert-manager 1.18.1: https://github.com/cert-manager/cert-manager/releases/tag/v1.18.1

ℹ Read the cert-manager 1.18 release-notes to learn more.

@hjoshi123 hjoshi123 mentioned this pull request Jul 24, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@hjoshi123 @erikgb @SgtCoDFish @cert-manager-bot @wallrj