Skip to content

Remove verify-licenses from ci-presubmit #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

Remove verify-licenses from ci-presubmit #5618

merged 1 commit into from
Dec 7, 2022

Conversation

SgtCoDFish
Copy link
Member

Pull Request Motivation

Since verify-licenses relies on third party servers it can flake for reasons unrelated to changes in a PR. cmrel#111 adds the ability for tests to be triggered only when a named file changes; this will remove the license check from our default "make test" in favour of the version which will be invoked only when go.mod is updated.

Kind

/kind flake

Release Note

NONE

@SgtCoDFish
remove verify-licenses from ci-presubmit
79bd127 
see cert-manager/release#111

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2022
@SgtCoDFish
Copy link
Member Author

/cherry-pick release-1.10

@jetstack-bot
Copy link
Contributor

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish
Copy link
Member Author

/cherry-pick release-1.9

@jetstack-bot
Copy link
Contributor

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish mentioned this pull request Dec 6, 2022
Merged
wallrj
wallrj approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold until the new prow config gets merged.

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Member Author

/unhold

Prow config has now merged!

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@wallrj wallrj mentioned this pull request Dec 6, 2022
Merged
@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-master-e2e-v1-25

@jetstack-bot jetstack-bot merged commit 2f24231 into cert-manager:master Dec 7, 2022
@jetstack-bot jetstack-bot added this to the v1.10 milestone Dec 7, 2022
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2022
Merged
@jetstack-bot
Copy link
Contributor

@SgtCoDFish: new pull request created: #5621

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2022
Merged
@jetstack-bot
Copy link
Contributor

@SgtCoDFish: new pull request created: #5622

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish deleted the no-licenses-ci-presubmit branch December 7, 2022 11:27
@SgtCoDFish SgtCoDFish mentioned this pull request Dec 12, 2022
Merged
@SgtCoDFish SgtCoDFish modified the milestones: v1.10, v1.11 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtCoDFish @jetstack-bot @wallrj