Fix build on OpenBSD (second take, revival of #1907) #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this commit is to fix the build for OpenBSD, but it may also solves the same potential problem for other systems without causing any harm. Suggested already twice, see capnproto#1846 (comment) capnproto#1907 (comment)
OpenBSD doesn't support user event filters yet, hence the build fails as it misses the symbol EVFILT_USER in the kqueue implementation in async-unix.c++. Fix that by not setting KJ_USE_KQUEUE on OpenBSD, so the poll()- based implementation is used instead. Suggested in capnproto@829d3f0#r1452600300
|
Thanks! |
theStack
added a commit
to theStack/bitcoin
that referenced
this pull request
Jun 6, 2025
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jun 11, 2025
… patch, correct SHA256SUM command) 8713e80 depends: fix SHA256SUM command on OpenBSD (use GNU mode output) (Sebastian Falbesoner) 2d93872 depends: add patch to fix capnp build on OpenBSD (Sebastian Falbesoner) Pull request description: This PR fixes the multiprocess depends build for OpenBSD by applying upstream patch capnproto/capnproto#2308 and switching the SHA256SUM command to output hash sums in the expected format (the default is BSD format [1], but we need GNU format [2], see commit message for details). Note that the hashing issue is only prevailing for packages defining the `$(package)_local_dir` variable (introduced in 5d105fb, part of #31741), where the following line of the `fetch_local_dir_sha256` function leads to the wrong output: https://github.com/bitcoin/bitcoin/blob/ae024137bda9fe189f4e7ccf26dbaffd44cbbeb6/depends/funcs.mk#L57 The first commit can be replaced with a simple capnp version bump once this is available in a release. Tested on OpenBSD 7.7 (x86_64) via ``` $ gmake -C depends MULTIPROCESS=1 NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_QR=1 NO_WALLET=1 NO_ZMQ=1 NO_USDT=1 ``` [1] example output: `SHA256 (/home/thestack/.vimrc) = 6ba69d100e8c5ca0488ded6293d4e5f740a6a5d5ace96cbcf0599c18d27389e4` [2] example output: `6ba69d100e8c5ca0488ded6293d4e5f740a6a5d5ace96cbcf0599c18d27389e4 /home/thestack/.vimrc` ACKs for top commit: Sjors: ACK 8713e80 hebasto: ACK 8713e80. fanquake: ACK 8713e80 Tree-SHA512: 178b8b41156e1f1eea101849110167d2636c3093b6a68c88a91a994f0750831aa02e415eb2793c522682c92cb3085de025300e0e2dee894e112dd7e1f495cc08
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 11, 2025
see capnproto/capnproto#2308 Github-Pull: bitcoin#32690 Rebased-From: 2d93872
jsarenik
pushed a commit
to jsarenik/bitcoin
that referenced
this pull request
Jun 19, 2025
PeterWrighten
pushed a commit
to PeterWrighten/bitcoin
that referenced
this pull request
Jul 15, 2025
saikiran57
pushed a commit
to saikiran57/bitcoin
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build on OpenBSD. It replaces the older #1907 by following its review suggestions (see commit messages for details):
Note that review comment about defining
AI_V4MAPPED(#1907 (comment)) is not relevant anymore, as this has been already fixed in #2202.Tested on OpenBSD 7.7 (amd64), compiled and ran the test executables.