Clone of #3740: "Fix multipass_tests target on Ubuntu ARM64 (#3739)" #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also ensures that all `<BACKEND>_ENABLED` definition checks occur at compile time, not run time, using #ifdef. Fixes #3739 (Building target multipass_tests fails on Ubuntu ARM64)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
==========================================
+ Coverage 88.86% 88.95% +0.09%
==========================================
Files 256 256
Lines 14557 14580 +23
==========================================
+ Hits 12936 12970 +34
+ Misses 1621 1610 -11 ☔ View full report in Codecov by Sentry. |
levkropp
previously approved these changes
Nov 28, 2024
|
Hey @levkropp, this did not merge well on the other side. I put up a matching PR there with analogous stuff. |
This addresses a review comment for #3739 (Building target multipass_tests fails on Ubuntu ARM64)
levkropp
approved these changes
Dec 2, 2024
|
Merge conflict in merge queues, as expected. Merging this and the private counterpart manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone (+ rebase) of #3740 in our repo, to run CI.
MULTI-1658