Skip to content

add snapcraft 24.04 aliases #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

add snapcraft 24.04 aliases #3613

merged 1 commit into from
Aug 2, 2024

Conversation

andrei-toterman
Copy link
Contributor

No description provided.

ricab
ricab requested changes Jul 31, 2024
View reviewed changes
src/platform/platform_shared.h Outdated
"core22",
"22.04",
"core24",
"24.04"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a comma ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie

ricab
ricab reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I'll just want to give it a spin on a couple of platforms before merging.

ricab
ricab approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked smoothly, thanks again.

@ricab ricab added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 52a9111 Aug 2, 2024
14 checks passed
@ricab ricab deleted the add-snapcraft-24 branch August 2, 2024 22:48
@andrei-toterman andrei-toterman added this to the 1.14.1 milestone Aug 3, 2024
ricab added a commit that referenced this pull request Sep 27, 2024
@ricab
Merge pull request #3613 from canonical/add-snapcraft-24
6f1d72f 
add snapcraft 24.04 aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei-toterman @ricab