fix: Operate does not correctly convert snapshot endTime #33920
Conversation
94f4b02 to
1ce4d12
Compare
| @@ -43,5 +43,18 @@ public void shouldPreferExtractingFromMetadataField() { | |||
| metadata.getVersion()), | |||
| ""); | |||
| assertThat(extracted).isEqualTo(metadata); | |||
| assertThat(extracted.getBackupId()) | |||
| .isEqualTo( | |||
| metadata.getBackupId()); // why backupId is not part of the Metadata.equals() method?? | |||
There was a problem hiding this comment.
Good question. I don't see a good reason why it wouldn't be part of the Metadata.equals(), so I suggest adding it there instead of the separate assertion.
There was a problem hiding this comment.
I don't want to add any risk :) But I will consider it later
| } | ||
|
|
||
| @Test | ||
| public void shouldExtractingBackupIdAsIntegerFromMetadataField() { |
There was a problem hiding this comment.
Naming nitpick: this should be shouldExtractBackupIdAsIntegerFromMetadataField
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-33920-to-stable/operate-8.5
git worktree add --checkout .worktree/backport-33920-to-stable/operate-8.5 backport-33920-to-stable/operate-8.5
cd .worktree/backport-33920-to-stable/operate-8.5
git reset --hard HEAD^
git cherry-pick -x 1ce4d123e9290b1913c2ce312081390443a54d3e
git push --force-with-lease |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.6
git worktree add -d .worktree/backport-33920-to-stable/8.6 origin/stable/8.6
cd .worktree/backport-33920-to-stable/8.6
git switch --create backport-33920-to-stable/8.6
git cherry-pick -x 1ce4d123e9290b1913c2ce312081390443a54d3e |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Description
Other problems were reported during Opensearch backup testing.
With opensearch,
snapshot.endTimeInMilliscan contain integer (0) or be null, and this is not well handled by OperateChecklist
Related issues
closes #