Skip to content

ci: run operate importer tests on PR #32570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

ci: run operate importer tests on PR #32570

merged 1 commit into from
Jun 2, 2025

Conversation

kristinkomschow
Copy link
Contributor

@kristinkomschow kristinkomschow commented May 27, 2025 •
edited
Loading

Description

Made old operate tests run for changes in the operate project and set timeout for the job to 90mins.

I will (back)port this to main, 8.6 and operate-8.5 (and see if I need to fix any tests there).

I'm not super familiar with github actions, so please let me know if there is anything that does not make sense.

Checklist

Related issues

relates to #24392

@github-actions github-actions bot added component/build-pipeline component/operate Related to the Operate component/team labels May 27, 2025
@kristinkomschow kristinkomschow force-pushed the 24392-op-nightly-import branch 4 times, most recently from d847d13 to 90232e8 Compare May 27, 2025 12:26
@kristinkomschow kristinkomschow marked this pull request as ready for review May 27, 2025 13:03
@kristinkomschow kristinkomschow requested a review from cmur2 May 27, 2025 13:05
@kristinkomschow kristinkomschow added backport main Forward-port a pull request to main backport stable/8.6 Backport a pull request to stable/8.6 backport stable/operate-8.5 labels May 27, 2025
cmur2
cmur2 reviewed May 28, 2025
View reviewed changes
@kristinkomschow kristinkomschow force-pushed the 24392-op-nightly-import branch from 90232e8 to 89edeb9 Compare May 30, 2025 07:12
@kristinkomschow
Copy link
Contributor Author

kristinkomschow commented May 30, 2025 •
edited
Loading

@cmur2
I lowered the timeout to 30 minutes.
While I was at it, I changed the name of the workflows to both be prefixed with "[Operate Legacy Importer]" (similar to what @matthewBearCamunda did for this) so their purpose is more clear and so we can reference them more easily.

@kristinkomschow kristinkomschow requested a review from cmur2 May 30, 2025 07:18
matthewBearCamunda
matthewBearCamunda reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@matthewBearCamunda matthewBearCamunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple naming nitpicks. I want to keep the naming similar to what other tests have so that the Legacy tests are organized when the tests run on a PR

.github/workflows/operate-test-importer.yml Outdated
@@ -1,11 +1,19 @@
name: Operate Run Test Importer
name: "[Operate Legacy Importer] Run Test Importer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming nitpick, but could you change this to [Legacy] Operate / [IT] Import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll change both. Feedback like this is mostly why I tagged you here 👍

.github/workflows/operate-test-migrate-elasticsearch-data.yml Outdated
@@ -1,11 +1,16 @@
name: Operate Run Test Migrate Elasticsearch Data
name: "[Operate Legacy Importer] Run Test Migrate Elasticsearch Data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nitpick

[Legacy] Operate / Migrate Elasticsearch Data

@kristinkomschow kristinkomschow force-pushed the 24392-op-nightly-import branch from 89edeb9 to adb21e4 Compare May 30, 2025 13:57
matthewBearCamunda
matthewBearCamunda approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@matthewBearCamunda matthewBearCamunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kristinkomschow
Copy link
Contributor Author

@cmur2 does everything look good from your perspective now as well?

@cmur2
Copy link
Member

cmur2 commented Jun 2, 2025

LGTM 👍🏼

@kristinkomschow kristinkomschow added this pull request to the merge queue Jun 2, 2025
Merged via the queue into stable/8.7 with commit be9718c Jun 2, 2025
59 checks passed
@kristinkomschow kristinkomschow deleted the 24392-op-nightly-import branch June 2, 2025 08:28
@backport-action backport-action mentioned this pull request Jun 2, 2025
Merged
@backport-action
Copy link
Collaborator

Created backport PR for main:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-32570-to-main
git worktree add --checkout .worktree/backport-32570-to-main backport-32570-to-main
cd .worktree/backport-32570-to-main
git reset --hard HEAD^
git cherry-pick -x adb21e4a08b4512d747f57f792ce65df1ca29d3e
git push --force-with-lease

@backport-action
Copy link
Collaborator

Created backport PR for stable/operate-8.5:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-32570-to-stable/operate-8.5
git worktree add --checkout .worktree/backport-32570-to-stable/operate-8.5 backport-32570-to-stable/operate-8.5
cd .worktree/backport-32570-to-stable/operate-8.5
git reset --hard HEAD^
git cherry-pick -x adb21e4a08b4512d747f57f792ce65df1ca29d3e
git push --force-with-lease

@backport-action backport-action mentioned this pull request Jun 2, 2025
Merged
@backport-action
Copy link
Collaborator

Created backport PR for stable/8.6:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-32570-to-stable/8.6
git worktree add --checkout .worktree/backport-32570-to-stable/8.6 backport-32570-to-stable/8.6
cd .worktree/backport-32570-to-stable/8.6
git reset --hard HEAD^
git cherry-pick -x adb21e4a08b4512d747f57f792ce65df1ca29d3e
git push --force-with-lease

@backport-action backport-action mentioned this pull request Jun 2, 2025
Merged
@kristinkomschow kristinkomschow mentioned this pull request Jun 2, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2025
@kristinkomschow
[Backport main] ci: run operate importer tests on PR (#32751)
e07bdd5 
# Description
Backport of #32570 to `main`.

Migration tests were removed with
#24620 so we only need the
adjustment for the importer tests.

relates to #24392
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2025
@kristinkomschow
[Backport stable/8.6] ci: run operate importer tests on PR (#32753)
d0259cd 
# Description
Backport of #32570 to `stable/8.6`.

relates to #24392
kristinkomschow added a commit that referenced this pull request Jun 12, 2025
@kristinkomschow
[Backport stable/operate-8.5] ci: run operate importer tests on PR (#…
0a2e2c9 
…32752)

# Description
Backport of #32570 to `stable/operate-8.5`.

Had to manually fix some of the tests and adjust the timeout to be higher since the tests need longer on this branch.

relates to #24392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewBearCamunda matthewBearCamunda matthewBearCamunda approved these changes

@cmur2 cmur2 Awaiting requested review from cmur2

Assignees
No one assigned
Labels
backport main Forward-port a pull request to main backport stable/operate-8.5 backport stable/8.6 Backport a pull request to stable/8.6 component/build-pipeline component/operate Related to the Operate component/team version:8.6.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristinkomschow @cmur2 @backport-action @matthewBearCamunda