-
Notifications
You must be signed in to change notification settings - Fork 693
test: cleanup IncidentNotifierIT resources #37409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56d432d
to
5da49e0
Compare
RomanJRW
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, LGTM 👍
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2025
## Description <!-- Describe the goal and purpose of this PR. --> The test uses ```java @MultiDbTestApplication(managedLifecycle = false) private static final TestCamundaApplication STANDALONE_CAMUNDA ``` so the application is not automatically stopped after the tests. Also the used http and camunda clients are not closed. Some logs found in the test logs of other tests (TasklistV1ApiFormPermissionsIT)! ``` Aug 27, 2025 10:33:34 PM io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue SEVERE: *~*~*~ Previous channel ManagedChannelImpl{logId=303, target=0.0.0.0:1406} was garbage collected without being shut down! ~*~*~* Make sure to call shutdown()/shutdownNow() java.lang.RuntimeException: ManagedChannel allocation site at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:102) at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:60) at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:51) at io.grpc.internal.ManagedChannelImplBuilder.build(ManagedChannelImplBuilder.java:731) at io.grpc.ForwardingChannelBuilder2.build(ForwardingChannelBuilder2.java:278) at io.camunda.client.impl.CamundaClientImpl.buildChannel(CamundaClientImpl.java:413) at io.camunda.client.impl.CamundaClientImpl.<init>(CamundaClientImpl.java:331) at io.camunda.client.impl.CamundaClientBuilderImpl.build(CamundaClientBuilderImpl.java:605) at io.camunda.it.orchestration.IncidentNotifierIT.shouldNotifyWebhookAboutIncident(IncidentNotifierIT.java:116) ``` ``` Caused by: java.net.BindException: Address already in use at java.base/sun.nio.ch.Net.bind0(Native Method) at java.base/sun.nio.ch.Net.bind(Net.java:565) ``` ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [ ] Enable backports when necessary (fex. [for bug fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes) or [for CI changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)). ## Related issues closes #
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test uses
so the application is not automatically stopped after the tests.
Also the used http and camunda clients are not closed.
Some logs found in the test logs of other tests (TasklistV1ApiFormPermissionsIT)!
Checklist
Related issues
closes #